Merge pull request #1828 from nwt/foreign-layer-url-validation

Properly validate multi-URL foreign layers

registry/storage/schema2manifesthandler.go

@@ -107,6 +107,7 @@ func (ms *schema2ManifestHandler) verifyManifest(ctx context.Context, mnfst sche
 					pu, err = url.Parse(u)
 					if err != nil || (pu.Scheme != "http" && pu.Scheme != "https") || pu.Fragment != "" {
 						err = errInvalidURL
+						break
 					}
 				}
 			}

registry/storage/schema2manifesthandler_test.go

@@ -78,6 +78,11 @@ func TestVerifyManifestForeignLayer(t *testing.T) {
 			[]string{"https://foo/bar", ""},
 			errInvalidURL,
 		},
+		{
+			foreignLayer,
+			[]string{"", "https://foo/bar"},
+			errInvalidURL,
+		},
 		{
 			foreignLayer,
 			[]string{"http://foo/bar"},