TrueCloudLab/distribution
14
0
Fork 3
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Avoid unnecessary type assertion in mfs driver

Browse source 
We already make sure the node in *dir

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
This commit is contained in:
Milos Gajdos 2023-09-03 23:23:25 +01:00
parent 59fd8656ac
commit a9d31ec7b9
No known key found for this signature in database
GPG key ID: 01300E5E6D417439
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
registry/storage/driver/inmemory/mfs.go
View file

@ -1,7 +1,6 @@
package inmemory
import (
"errors"
"fmt"
"io"
"path"
@ -98,13 +97,12 @@ func (d *dir) list(p string) ([]string, error) {
return nil, errIsNotDir
}
dir, ok := n.(*dir)
if !ok {
return nil, errors.New("not a directory")
}
// NOTE(milosgajdos): this is safe to do because
// n can only be *dir due to the compile time check
dirChildren := n.(*dir).children
children := make([]string, 0, len(dir.children))
for _, child := range dir.children {
children := make([]string, 0, len(dirChildren))
for _, child := range dirChildren {
children = append(children, child.path())
}