TrueCloudLab/distribution
13
0
Fork 3
Code Issues 3 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Move registry client internal

Browse source 
Our registry client is not currently in a good place to be used as the
reference OCI Distribution client implementation. But the registry proxy
currently depends on it. Make the registry client internal to the
distribution application to remove it from the API surface area (and any
implied compatibility promises) of distribution/v3@v3.0.0 without
breaking the proxy.

Signed-off-by: Cory Snider <csnider@mirantis.com>
This commit is contained in:
Cory Snider 2023-10-24 12:26:38 -04:00
parent 708bc6f3e9
commit cc23fdacff
18 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
registry/client/auth/api_version.go → internal/client/auth/api_version.go
View file

0
registry/client/auth/challenge/addr.go → internal/client/auth/challenge/addr.go
View file

0
registry/client/auth/challenge/authchallenge.go → internal/client/auth/challenge/authchallenge.go
View file

0
registry/client/auth/challenge/authchallenge_test.go → internal/client/auth/challenge/authchallenge_test.go
View file

6
registry/client/auth/session.go → internal/client/auth/session.go
View file

@ -11,9 +11,9 @@ import (
"sync" "sync"
"time" "time"
"github.com/distribution/distribution/v3/registry/client" "github.com/distribution/distribution/v3/internal/client"
"github.com/distribution/distribution/v3/registry/client/auth/challenge" "github.com/distribution/distribution/v3/internal/client/auth/challenge"
"github.com/distribution/distribution/v3/registry/client/transport" "github.com/distribution/distribution/v3/internal/client/transport"
) )
var ( var (

4
registry/client/auth/session_test.go → internal/client/auth/session_test.go
View file

@ -9,8 +9,8 @@ import (
"testing" "testing"
"time" "time"
"github.com/distribution/distribution/v3/registry/client/auth/challenge" "github.com/distribution/distribution/v3/internal/client/auth/challenge"
"github.com/distribution/distribution/v3/registry/client/transport" "github.com/distribution/distribution/v3/internal/client/transport"
"github.com/distribution/distribution/v3/testutil" "github.com/distribution/distribution/v3/testutil"
) )

0
registry/client/blob_writer.go → internal/client/blob_writer.go
View file

0
registry/client/blob_writer_test.go → internal/client/blob_writer_test.go
View file

2
registry/client/errors.go → internal/client/errors.go
View file

@ -8,8 +8,8 @@ import (
"mime" "mime"
"net/http" "net/http"
"github.com/distribution/distribution/v3/internal/client/auth/challenge"
"github.com/distribution/distribution/v3/registry/api/errcode" "github.com/distribution/distribution/v3/registry/api/errcode"
"github.com/distribution/distribution/v3/registry/client/auth/challenge"
) )
// ErrNoErrorsInBody is returned when an HTTP response body parses to an empty // ErrNoErrorsInBody is returned when an HTTP response body parses to an empty

0
registry/client/errors_test.go → internal/client/errors_test.go
View file

2
registry/client/repository.go → internal/client/repository.go
View file

@ -15,8 +15,8 @@ import (
"time" "time"
"github.com/distribution/distribution/v3" "github.com/distribution/distribution/v3"
"github.com/distribution/distribution/v3/internal/client/transport"
v2 "github.com/distribution/distribution/v3/registry/api/v2" v2 "github.com/distribution/distribution/v3/registry/api/v2"
"github.com/distribution/distribution/v3/registry/client/transport"
"github.com/distribution/distribution/v3/registry/storage/cache" "github.com/distribution/distribution/v3/registry/storage/cache"
"github.com/distribution/distribution/v3/registry/storage/cache/memory" "github.com/distribution/distribution/v3/registry/storage/cache/memory"
"github.com/distribution/reference" "github.com/distribution/reference"

0
registry/client/repository_test.go → internal/client/repository_test.go
View file

0
registry/client/transport/http_reader.go → internal/client/transport/http_reader.go
View file

0
registry/client/transport/http_reader_test.go → internal/client/transport/http_reader_test.go
View file

0
registry/client/transport/transport.go → internal/client/transport/transport.go
View file

4
registry/proxy/proxyauth.go
View file

@ -6,8 +6,8 @@ import (
"strings" "strings"
"github.com/distribution/distribution/v3/context" "github.com/distribution/distribution/v3/context"
"github.com/distribution/distribution/v3/registry/client/auth" "github.com/distribution/distribution/v3/internal/client/auth"
"github.com/distribution/distribution/v3/registry/client/auth/challenge" "github.com/distribution/distribution/v3/internal/client/auth/challenge"
) )
const challengeHeader = "Docker-Distribution-Api-Version" const challengeHeader = "Docker-Distribution-Api-Version"

4
registry/proxy/proxymanifeststore_test.go
View file

@ -7,9 +7,9 @@ import (
"testing" "testing"
"github.com/distribution/distribution/v3" "github.com/distribution/distribution/v3"
"github.com/distribution/distribution/v3/internal/client/auth"
"github.com/distribution/distribution/v3/internal/client/auth/challenge"
"github.com/distribution/distribution/v3/manifest/schema2" "github.com/distribution/distribution/v3/manifest/schema2"
"github.com/distribution/distribution/v3/registry/client/auth"
"github.com/distribution/distribution/v3/registry/client/auth/challenge"
"github.com/distribution/distribution/v3/registry/proxy/scheduler" "github.com/distribution/distribution/v3/registry/proxy/scheduler"
"github.com/distribution/distribution/v3/registry/storage" "github.com/distribution/distribution/v3/registry/storage"
"github.com/distribution/distribution/v3/registry/storage/cache/memory" "github.com/distribution/distribution/v3/registry/storage/cache/memory"

8
registry/proxy/proxyregistry.go
View file

@ -11,10 +11,10 @@ import (
"github.com/distribution/distribution/v3" "github.com/distribution/distribution/v3"
"github.com/distribution/distribution/v3/configuration" "github.com/distribution/distribution/v3/configuration"
dcontext "github.com/distribution/distribution/v3/context" dcontext "github.com/distribution/distribution/v3/context"
"github.com/distribution/distribution/v3/registry/client" "github.com/distribution/distribution/v3/internal/client"
"github.com/distribution/distribution/v3/registry/client/auth" "github.com/distribution/distribution/v3/internal/client/auth"
"github.com/distribution/distribution/v3/registry/client/auth/challenge" "github.com/distribution/distribution/v3/internal/client/auth/challenge"
"github.com/distribution/distribution/v3/registry/client/transport" "github.com/distribution/distribution/v3/internal/client/transport"
"github.com/distribution/distribution/v3/registry/proxy/scheduler" "github.com/distribution/distribution/v3/registry/proxy/scheduler"
"github.com/distribution/distribution/v3/registry/storage" "github.com/distribution/distribution/v3/registry/storage"
"github.com/distribution/distribution/v3/registry/storage/driver" "github.com/distribution/distribution/v3/registry/storage/driver"