Merge pull request #858 from docker/CI

Multi-go test

circle.yml

@@ -1,40 +1,117 @@
+# Pony-up!
 machine:
   pre:
-    - curl -o go.tar.gz -sL https://golang.org/dl/go1.4rc2.linux-amd64.tar.gz
+  # Install gvm
-    - sudo rm -rf /usr/local/go
+    - bash < <(curl -s -S -L https://raw.githubusercontent.com/moovweb/gvm/1.0.22/binscripts/gvm-installer)
-    - sudo tar -C /usr/local -xzf go.tar.gz
+
-    - sudo chmod a+w /usr/local/go/src/
+  post:
+  # Install many go versions
+    - gvm install go1.3.3 -B --name=old
+    - gvm install go1.4 -B --name=stable
+    # - gvm install tip --name=bleed
+
+  environment:
+  # Convenient shortcuts to "common" locations
+    CHECKOUT: /home/ubuntu/$CIRCLE_PROJECT_REPONAME
+    BASE_DIR: src/github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME
+  # Trick circle brainflat "no absolute path" behavior
+    BASE_OLD: ../../../$HOME/.gvm/pkgsets/old/global/$BASE_DIR
+    BASE_STABLE: ../../../$HOME/.gvm/pkgsets/stable/global/$BASE_DIR
+  # BASE_BLEED: ../../../$HOME/.gvm/pkgsets/bleed/global/$BASE_DIR
+  # Workaround Circle parsing dumb bugs and/or YAML wonkyness
+    CIRCLE_PAIN: "mode: set"
 
   hosts:
+  # Not used yet
     fancy: 127.0.0.1
 
 dependencies:
+  pre:
+  # Copy the code to the gopath of all go versions
+    - >
+      gvm use old &&
+      mkdir -p "$(dirname $BASE_OLD)" &&
+      cp -R "$CHECKOUT" "$BASE_OLD"
+
+    - >
+      gvm use stable &&
+      mkdir -p "$(dirname $BASE_STABLE)" &&
+      cp -R "$CHECKOUT" "$BASE_STABLE"
+
+    # - >
+    #   gvm use bleed &&
+    #   mkdir -p "$(dirname $BASE_BLEED)" &&
+    #   cp -R "$CHECKOUT" "$BASE_BLEED"
+
+  override:
+  # Install dependencies for every copied clone/go version
+    - gvm use old && go get -t -d -v ./...:
+        pwd: $BASE_OLD
+
+    - gvm use stable && go get -t -d -v ./...:
+        pwd: $BASE_STABLE
+
+    # - gvm use bleed && go get -t -d -v ./...:
+    #   pwd: $BASE_BLEED
+
   post:
-    - go get github.com/axw/gocov/gocov
+  # For the stable go version, additionally install linting tools
-    - go get github.com/mattn/goveralls
+    - >
-    - go get github.com/golang/lint/golint
+      gvm use stable &&
+      go get github.com/axw/gocov/gocov github.com/mattn/goveralls github.com/golang/lint/golint
 
 test:
   pre:
-    - go version
+  # Output the go versions we are going to test
+    - gvm use old && go version
+    - gvm use stable && go version
+    # - gvm use bleed && go version
+
+  # FMT
+    - gvm use stable && test -z "$(gofmt -s -l . | tee /dev/stderr)":
+        pwd: $BASE_STABLE
+
+  # VET
+    - gvm use stable && go vet ./...:
+        pwd: $BASE_STABLE
+
+  # LINT
+    - gvm use stable && test -z "$(golint ./... | tee /dev/stderr)":
+        pwd: $BASE_STABLE
+
   override:
-    - test -z "$(gofmt -s -l . | tee /dev/stderr)"
+  # Test every version we have (but stable)
-    - go vet ./...
+    - gvm use old; go test -test.v -test.short ./...:
-    - test -z "$(golint ./... | tee /dev/stderr)"
+        timeout: 600
-    - go test -test.v -test.short ./...
+        pwd: $BASE_OLD
 
-    # Disabling the race detector due to massive memory usage.
+    # - gvm use bleed; go test -test.v -test.short ./...:
-    # - go test -race -test.v ./...:
     #     timeout: 600
+    #     pwd: $BASE_BLEED
 
-    # TODO(stevvooe): The following is an attempt at using goveralls but it
+  # Test stable, and report
-    # just doesn't work. goveralls requires a single profile file to be
+  # Preset the goverall report file
-    # submitted at once, but can't run all of the tests for all the packages
+    - echo "$CIRCLE_PAIN" > ~/goverage.report
-    # at once. The command below attempts to fix this but fails because it
+    - gvm use stable; go list ./... | xargs -L 1 -I{} rm -f $GOPATH/src/{}/coverage.out:
-    # creates a new "job" for run of coveralls, making it so that the coverage
+        pwd: $BASE_STABLE
-    # is partially reported a large number of times.
 
-    # - cd $HOME/.go_project/src/github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME && go list ./... | xargs -I{} goveralls -service circleci -repotoken $COVERALLS_TOKEN -race {}
+    - gvm use stable; go list ./... | xargs -L 1 -I{} go test -test.short -coverprofile=$GOPATH/src/{}/coverage.out {}:
+        timeout: 600
+        pwd: $BASE_STABLE
+
+  post:
+  # Aggregate and report to coveralls
+    - gvm use stable; go list ./... | xargs -L 1 -I{} cat "$GOPATH/src/{}/coverage.out" | grep -v "$CIRCLE_PAIN" >> ~/goverage.report:
+        pwd: $BASE_STABLE
+    - gvm use stable; goveralls -service circleci -coverprofile=/home/ubuntu/goverage.report -repotoken $COVERALLS_TOKEN:
+        pwd: $BASE_STABLE
+
+  ## Notes
+  # Disabled the -race detector due to massive memory usage.
+  # Do we want these as well?
+  # - go get code.google.com/p/go.tools/cmd/goimports
+  # - test -z "$(goimports -l -w ./... | tee /dev/stderr)"
+  # http://labix.org/gocheck
 
 general:
   branches:
@@ -44,23 +121,3 @@ general:
       - 0.8
       - 0.9
       - 1.0
-  # This doesn't work, but it would be nice if it did.
-  # build_dir: ../.go_project/src/github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME
-
-# notify:
-#     email:
-#         recipients:
-#             - distribution@docker.com
-
-#     slack:
-#         team: docker
-#         channel: "#dt"
-#         username: mom
-#         token: {{SLACK_TOKEN}}
-#         on_success: false
-#         on_failure: true
-
-  # Do we want these as well?
-  # - go get code.google.com/p/go.tools/cmd/goimports
-  # - test -z "$(goimports -l -w ./... | tee /dev/stderr)"
-  # http://labix.org/gocheck