TrueCloudLab/distribution
13
0
Fork 3
Code Issues 3 Pull requests Projects Releases 2 Packages Wiki Activity Actions

notifications: use consistent names for test tables

Browse source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-04-30 14:40:44 +02:00
parent f4be328bff
commit e9ac1728e6
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
notifications/sinks_test.go
View file

@ -73,7 +73,7 @@ func TestIgnoredSink(t *testing.T) {
expected events.Event expected events.Event
} }
cases := []testcase{ tests := []testcase{
{nil, nil, blob}, {nil, nil, blob},
{[]string{"other"}, []string{"other"}, blob}, {[]string{"other"}, []string{"other"}, blob},
{[]string{"blob", "manifest"}, []string{"other"}, nil}, {[]string{"blob", "manifest"}, []string{"other"}, nil},
@ -81,22 +81,22 @@ func TestIgnoredSink(t *testing.T) {
{[]string{"other"}, []string{"pull", "push"}, nil}, {[]string{"other"}, []string{"pull", "push"}, nil},
} }
for _, c := range cases { for _, tc := range tests {
ts := &testSink{} ts := &testSink{}
s := newIgnoredSink(ts, c.ignoreMediaTypes, c.ignoreActions) s := newIgnoredSink(ts, tc.ignoreMediaTypes, tc.ignoreActions)
if err := s.Write(blob); err != nil { if err := s.Write(blob); err != nil {
t.Fatalf("error writing event: %v", err) t.Fatalf("error writing event: %v", err)
} }
ts.mu.Lock() ts.mu.Lock()
if !reflect.DeepEqual(ts.event, c.expected) { if !reflect.DeepEqual(ts.event, tc.expected) {
t.Fatalf("unexpected event: %#v != %#v", ts.event, c.expected) t.Fatalf("unexpected event: %#v != %#v", ts.event, tc.expected)
} }
ts.mu.Unlock() ts.mu.Unlock()
} }
cases = []testcase{ tests = []testcase{
{nil, nil, manifest}, {nil, nil, manifest},
{[]string{"other"}, []string{"other"}, manifest}, {[]string{"other"}, []string{"other"}, manifest},
{[]string{"blob"}, []string{"other"}, manifest}, {[]string{"blob"}, []string{"other"}, manifest},
@ -105,17 +105,17 @@ func TestIgnoredSink(t *testing.T) {
{[]string{"other"}, []string{"pull", "push"}, nil}, {[]string{"other"}, []string{"pull", "push"}, nil},
} }
for _, c := range cases { for _, tc := range tests {
ts := &testSink{} ts := &testSink{}
s := newIgnoredSink(ts, c.ignoreMediaTypes, c.ignoreActions) s := newIgnoredSink(ts, tc.ignoreMediaTypes, tc.ignoreActions)
if err := s.Write(manifest); err != nil { if err := s.Write(manifest); err != nil {
t.Fatalf("error writing event: %v", err) t.Fatalf("error writing event: %v", err)
} }
ts.mu.Lock() ts.mu.Lock()
if !reflect.DeepEqual(ts.event, c.expected) { if !reflect.DeepEqual(ts.event, tc.expected) {
t.Fatalf("unexpected event: %#v != %#v", ts.event, c.expected) t.Fatalf("unexpected event: %#v != %#v", ts.event, tc.expected)
} }
ts.mu.Unlock() ts.mu.Unlock()
} }