ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated
We need to look into this; can we remove it, or is there a replacement? Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
parent
84a85a4048
commit
ebe9d67446
2 changed files with 6 additions and 7 deletions
|
@ -526,7 +526,7 @@ func TestNewAccessControllerPemBlock(t *testing.T) {
|
|||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if len(ac.(*accessController).rootCerts.Subjects()) != 2 {
|
||||
if len(ac.(*accessController).rootCerts.Subjects()) != 2 { //nolint:staticcheck // FIXME(thaJeztah): ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated since Go 1.18: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)
|
||||
t.Fatal("accessController has the wrong number of certificates")
|
||||
}
|
||||
}
|
||||
|
|
|
@ -221,11 +221,10 @@ func (registry *Registry) ListenAndServe() error {
|
|||
}
|
||||
|
||||
tlsConf := &tls.Config{
|
||||
ClientAuth: tls.NoClientCert,
|
||||
NextProtos: nextProtos(config),
|
||||
MinVersion: tlsMinVersion,
|
||||
PreferServerCipherSuites: true,
|
||||
CipherSuites: tlsCipherSuites,
|
||||
ClientAuth: tls.NoClientCert,
|
||||
NextProtos: nextProtos(config),
|
||||
MinVersion: tlsMinVersion,
|
||||
CipherSuites: tlsCipherSuites,
|
||||
}
|
||||
|
||||
if config.HTTP.TLS.LetsEncrypt.CacheFile != "" {
|
||||
|
@ -262,7 +261,7 @@ func (registry *Registry) ListenAndServe() error {
|
|||
}
|
||||
}
|
||||
|
||||
for _, subj := range pool.Subjects() {
|
||||
for _, subj := range pool.Subjects() { //nolint:staticcheck // FIXME(thaJeztah): ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated since Go 1.18: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)
|
||||
dcontext.GetLogger(registry.app).Debugf("CA Subject: %s", string(subj))
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue