TrueCloudLab/distribution
13
0
Fork 3
Code Issues 3 Pull requests Projects Releases 2 Packages Wiki Activity Actions
1866 commits 2 branches 61 tags 129 MiB
Commit graph

44 commits

Author SHA1 Message Date
Stefan Majewsky
4c9bed2507 don't swallow errors in Swift driver's GetContent() 
In 326c3a9c49, which was only intended to
be a refactoring commit, the behavior of this block subtly changed so
that unknown types of errors would be swallowed instead of propagated.

I noticed this while investigating an error similar to #1539 aka
docker/docker#21290. It appears that during GetContent() for a
hashstate, the Swift proxy produces an error. Since this error was
silently swallowed, an empty []byte is used to restart the hash, then
producing the digest of the empty string instead of the layer's digest.

This PR will not fix the issue, but it should make the actual error more
visible by propagating it into `blobWriter#resumeDigest' and
'blobWriter#validateBlob', respectively.

Signed-off-by: Stefan Majewsky <stefan.majewsky@sap.com>
 2016-03-30 16:11:29 +02:00
Brian Bland
7fd1db9312 Updates Swift driver to support new storagedriver.FileWriter interface 
Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-03-08 16:38:39 -08:00
davidli
79d4d7f546 driver/swift: treat empty object list as a PathNotFoundError 
Swift returns an empty object list when trying to read a non-existing object path, treat it as a
PathNotFoundError when trying to list a non existing virtual directory.

Signed-off-by: David li <wenquan.li@hpe.com>
 2015-12-08 12:04:04 -08:00
Sylvain Baubeau
ef4ab7a885 Use bulk delete to remove segments in Swift driver 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-12-04 12:16:49 +01:00
Richard Scothern
a33095af80 Merge pull request #1141 from lebauce/swift-no-missing-segment 
Ensure read after write for segments
 2015-11-10 10:39:43 -08:00
Aaron Lehmann
6664a1384e Fix empty delete requests with Swift fs driver 
The Delete method lists objects under the given path and tries to delete
all of them with a bulk delete request. If the path has no objects
underneath it, the body of this request will be empty, which causes
HTTP-level issues. Specifically, Go's HTTP client senses the empty
request buffer and doesn't include a Content-Length, which causes the
Swift server to fail the request.

This commit fixes the problem by avoiding sending empty bulk delete
requests. This is the correct thing to do anyway, since there's no
reason to request deletion of zero objects.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2015-11-09 15:33:05 -08:00
amitshukla
9637cb40cd Fix for issue 664: https://github.com/docker/distribution/issues/664 
Errors thrown by storage drivers don't have the name of the driver, causing user
confusion about whether the error is coming from Docker or from a storage driver.
This change adds the storage driver name to each error message.

This required changing ErrUnsupportedDriver to a type, leading to code changes
whenever ErrUnsupportedDriver is used.  The tests check whether the driver name
appears in the error message.

Signed-off-by: Amit Shukla <amit.shukla@docker.com>
 2015-11-03 11:19:17 -08:00
Sylvain Baubeau
3ff8af326b Ensure read after write for segments 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-11-03 17:09:52 +01:00
Sylvain Baubeau
7c3281861f Add support for temporary URL for Swift driver 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-11-03 09:59:50 +01:00
Richard Scothern
61a4a1362c Merge pull request #950 from jackpgriffin/master 
Skip creating swift container if already exists
 2015-10-01 10:15:54 -07:00
Jack Griffin
2749bcdc28 Skip creating swift container if already exists 
Signed-off-by: Jack Griffin <jackpg14@gmail.com>
 2015-09-04 18:53:17 +00:00
Hua Wang
ddb689ef8b Add TrustId parameter to swift driver 
github/ncw/swift has added support for trust, so let's add it.

Signed-off-by: Hua Wang <wanghua.humble@gmail.com>
 2015-09-02 15:05:29 +08:00
davidli
d1b4bae078 Remove IPC support from test file 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
cca15a76f1 Catch either missing containers or objects 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
b4cf6c053b Do not use Swift server side copy for manifests to handle >5G files 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
326c3a9c49 Inline Swift errors handling 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
15d567671b Retrieve all the objects using pagination 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
49582a6188 Do not create objects for directories 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
ed08d8d4e0 Refactor segment path concatenation code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
91e17e10cd Use http.StatusRequestedRangeNotSatisfiable instead of error code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
f4ca709d70 Use file instead of filepath as it may cause troubles on Windows 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
78d722e708 Protect against deletion of objects with the same prefix 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
61e3bce794 Show distribution version in User-Agent 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
f256797cac Do not use suite style testing for Swift specific tests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
53e80944f1 Rename environment variables to run Swift testsuite 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
d0dd36125c Check file has been opened before closing it 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
1a80ec340b Rename DriverParameters structure to Parameters 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
2846913552 Change folder mime type to application/vnc.swift.directory 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
33028c11a7 Add code documentation 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
f21cbcebc6 Do not read segment if no padding is necessary 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
3242378e1b Improve 404 errors handling 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
57cef57e1b Use only one Swift container for both files and manifests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
a40502ec02 Increase default chunk size to 20M 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
davidli
af99dbd6bf Add support for Openstack Identity v3 API 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
3fb42a1502 Use 'prefix' parameter instead of 'path' when listing files 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
1c01ca4b39 Create full folder hierarchy instead of just the top level folder 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
c4d845cb6c Remove one level of indentation in swift path handling code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
4497d6c973 Use mitchellh/mapstructure library to parse Swift parameters 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
2632fd9dc8 Move Dynamic Large Object handling to dedicated methods 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
d8d50fb0e0 Simplify code that handles non existing manifests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
5e650a820a Handle error during copy of original content 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
nevermosby
7372c13f29 Update the import path for swift driver test 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:09 +02:00
davidli
6dc1596be4 Use gofmt to format the code of swift driver. 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
ea7c53df08 Add Openstack Swift storage driver 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:08 +02:00