Commit graph

5226 commits

Author SHA1 Message Date
Milos Gajdos
b655f9dda4
Merge pull request #3692 from aaronlehmann/get-request-in-example
Change GET in example request to POST
2022-07-18 17:08:15 +01:00
Aaron Lehmann
c3074d095e Change GET in example request to POST
The example shows a `GET` request to `/callback`, but it looks like it's
intending to show the `POST` request made by the registry to a
notificaitons endpoint. Unless I'm missing something, no `GET` request
should be involved.

Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2022-07-18 08:39:47 -07:00
James Hewitt
57ea90fee7
Update the BUILDING.md to a world with modules
The current doc says to use go get to pull the source code, which no
longer works by default on recent versions of go. Also, the makefile has
changed to not run all the validation automatically, and to use buildx
for some commands.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-07-13 13:52:55 +01:00
Maurice Sotzny
3801e37d16
Fix grammar mistake
Signed-off-by: Maurice Sotzny <ailuridae@users.noreply.github.com>
2022-07-13 12:38:29 +02:00
James Hewitt
87d9edf770
Add build tags to BUILDING.md
Easier to see what build tags there are and what they are used for.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-07-12 14:55:06 +01:00
Aaron Lehmann
853e2e92d8 Do not recreate mux router for each incoming request
(*App).context, called in the HTTP handler on each request, creates a
URLBuilder, which involves calling Router(). This shows up in profiles a
hot spot because it involves compiling the regexps which define all the
routes. For efficiency, cache the router and return the same object each
time.

It appears to be safe to reuse the router because GetRoute is the only
method ever called on the returned router object.

Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2022-07-08 14:17:17 -07:00
James Hewitt
d5b2f94c7c
Say when a config error is caused by an env var
Without this, the log message for the user indicates a problem with the
yaml file, so identifying the actual error is hard. This change fixes
the output so that the incorrect environment variable is easy to spot.

Fixes #3653

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-07-08 17:42:19 +01:00
James Hewitt
c895369b77
Review contributing for Docker references
As the project has transitioned from Docker to CNCF, clean up the
contributing.md to reflect that:
- CNCF slack
- CNCF maintainers
- Use with other container tools

Fixes #3550

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-07-08 13:52:12 +01:00
James Hewitt
9e74396f31
Fix API doc parameter placeholder: last
Last is not an integer, but is the last returned value to start the
pagination from.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-07-07 12:17:10 +01:00
Milos Gajdos
8857a19487
Merge pull request #3669 from sudo-bmitch/pr-manifest-comment
Fix comment for manifest list
2022-07-02 08:19:10 +01:00
Brandon Mitchell
bbeffe6a12 Fix comment for manifest list
Signed-off-by: Brandon Mitchell <git@bmitch.net>
2022-06-27 19:43:41 -04:00
Antonio Ojea
53a6f7d7aa registry: support ipv6 addresses
Current registry reference use a subset of dns and IPv4 addresses to
represent a registry domain.

Since registries are mostly compatible with rfc3986, that defines the
URI generic syntax, this adds support for IPv6 enclosed in squared
brackets based on the mentioned rfc.

The regexp is only expanded to match on IPv6 addreses enclosed between
square brackets, considering only regular IPv6 addresses represented
as compressed or uncompressed, excluding special IPv6 address
representations.

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2022-06-27 09:54:37 +02:00
Milos Gajdos
3e4f8a0ab1
Merge pull request #3630 from raxod502/patch-1
Explain important caveat in htpasswd tutorial
2022-06-20 09:01:56 +01:00
Milos Gajdos
b5e2f3f33d
Merge pull request #3658 from iasoon/patch-1
fix json syntax error in error api spec
2022-06-12 16:19:01 +01:00
iasoon
8628eab487 fix json syntax error in error api spec
Signed-off-by: Ilion Beyst <ilion.beyst@gmail.com>
2022-06-12 12:29:45 +02:00
Steve Lasker
0eca211294
Merge pull request #3655 from Jamstah/mailing-list
Update maintainers mailing list
2022-06-08 09:18:12 -07:00
James Hewitt
ba29eb8a41
Update maintainers mailing list
Domain was incorrect

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
2022-06-08 16:31:08 +01:00
Hayley Swimelar
ffbd94cbe2
Merge pull request #3651 from thaJeztah/remove_old_comment
go.mod: remove outdated comment
2022-05-26 07:23:53 -07:00
Hayley Swimelar
c7387f4d38
Merge pull request #3649 from thaJeztah/bump_alpine
Fix CVE-2022-28391 by bumping alpine from 3.15 to 3.16
2022-05-26 07:01:42 -07:00
Sebastiaan van Stijn
3bd75427a8
go.mod: remove outdated comment
The replace rule was removed in ec47096efc,
so this comment no longer applies.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-05-26 13:33:56 +02:00
Silvin Lubecki
9f2bc25b7a
Fix CVE-2022-28391 by bumping alpine from 3.15 to 3.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-05-26 13:16:17 +02:00
Milos Gajdos
c202b9b0d7
Merge pull request #3642 from thaJeztah/update_deps
vendor: github.com/prometheus/client_golang v1.12.1
2022-05-16 12:20:11 +01:00
Sebastiaan van Stijn
ec47096efc
vendor: github.com/prometheus/client_golang v1.12.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-05-05 18:43:00 +02:00
Milos Gajdos
985711c1f4
Merge pull request #3643 from thaJeztah/update_go_1.18
update to go 1.18 (continue testing against 1.17)
2022-05-05 16:55:52 +01:00
Sebastiaan van Stijn
6e8dd268a8
update to go 1.18 (continue testing against 1.17)
Go 1.16 reached end of life, so update to the current version of Go, but also
run CI on the previous version (which is still supported).

We should probably also decide wether or not we want the Dockerfiles to pin to
a specific minor version; this makes the releases more deterministic.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-05-05 10:36:28 +02:00
Sebastiaan van Stijn
18b4da91a4
Update golang-ci-lint to v1.45.x
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-05-05 10:27:39 +02:00
Milos Gajdos
7a6b9e3042
Merge pull request #3640 from crazy-max/lint
lint target and workflow job
2022-05-04 19:04:56 +01:00
CrazyMax
7548c315f8
cleanup old check behavior
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-05-04 11:12:19 +02:00
CrazyMax
26a586cf39
lint target and workflow job
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-05-04 11:12:19 +02:00
Milos Gajdos
7846381718
Merge pull request #3641 from crazy-max/use-xx
Dockerfile: switch to xx
2022-05-04 08:25:34 +01:00
CrazyMax
87f93ede9e
Dockerfile: switch to xx
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-05-03 20:07:07 +02:00
Milos Gajdos
edf5aa3c39
Merge pull request #3634 from crazy-max/dev-vendor
validate and update vendor targets
2022-04-27 08:49:07 +01:00
João Pereira
a7fc49b067
Merge pull request #3622 from ddelange/patch-1
Support all S3 instant retrieval storage classes
2022-04-26 10:23:14 +01:00
Bracken Dawson
b2b3f86039
Remove workaround from 2.1.1 for faulty 2.1.0 manifest links
This reverts commit 06a098c632

This changes the function of linkedBlobStatter.Clear(). It was either removing the first of two possible manifest links or returning nil if none were found. Now it once again it removes only the valid manifest link or returns an error if none are found.

Signed-off-by: Bracken Dawson <abdawson@gmail.com>
2022-04-25 13:01:44 +01:00
Milos Gajdos
5fe693474e
Merge pull request #2291 from lucab/ups/spec-fixes
docs/spec: provide valid manifest examples
2022-04-22 18:01:03 +01:00
Wang Yan
9332c3cc7b
Merge pull request #3498 from hasheddan/md-links-oauth
(docs) Fix rendering of markdown links in OAuth docs HTML
2022-04-23 00:33:20 +08:00
CrazyMax
de240721ff
cleanup old vendor validation behavior
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-04-22 16:24:54 +02:00
CrazyMax
c052659543
mod-outdated target to check for outdated dependencies
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-04-22 16:24:54 +02:00
CrazyMax
ffa3019c1f
validate and update vendor target
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-04-22 15:32:01 +02:00
Milos Gajdos
27b5563245
Merge pull request #3624 from milosgajdos/aws-s3-listv2
Update s3 ListObjects to V2 API
2022-04-22 13:34:13 +01:00
Milos Gajdos
1b7ce0e691
Merge pull request #3632 from drycc/main
Add forcepathstyle parameter for s3
2022-04-22 13:29:57 +01:00
duanhongyi
15de9e21ba Add forcepathstyle parameter for s3
Signed-off-by: duanhongyi <duanhongyi@doopai.com>
2022-04-20 08:44:12 +08:00
Radon Rosborough
d64056afdc Explain important caveat in htpasswd tutorial
Signed-off-by: Radon Rosborough <radon.neon@gmail.com>
2022-04-15 20:02:57 -07:00
Milos Gajdos
48f3d9ad29
Fix typo
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
2022-04-09 12:31:27 +01:00
Milos Gajdos
8eab5d1bd6
Update s3 ListObjects to V2 API
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
2022-04-09 12:16:46 +01:00
TaylorKanper
18b2b9f455 Added some secure compilation options PIE
Signed-off-by: TaylorKanper <tony_kanper@hotmail.com>
2022-04-06 08:41:29 +08:00
Milos Gajdos
cd51f38d53
Merge pull request #3181 from pimuzzo/s3-transfer-accelerate
Add new parameter accelerate to S3 storage driver.
2022-04-04 18:50:50 +01:00
Simone Locci
80952c9e2b
Rename s3accelerate parameter to accelerate
Signed-off-by: Simone Locci <simonelocci88@gmail.com>
2022-04-04 19:35:21 +02:00
Simone Locci
ea27621d4a
Fix review
Signed-off-by: Simone Locci <simonelocci88@gmail.com>
2022-04-04 19:35:09 +02:00
Kirat Singh
51c0c8148a
Add new parameter s3accelerate to S3 storage driver.
If s3accelerate is set to true then we turn on S3 Transfer
Acceleration via the AWS SDK.  It defaults to false since this is an
opt-in feature on the S3 bucket.

Signed-off-by: Kirat Singh <kirat.singh@wsq.io>
Signed-off-by: Simone Locci <simonelocci88@gmail.com>
2022-04-04 19:34:57 +02:00