Richard Scothern
8745d31f60
Merge pull request #1419 from aaronlehmann/safer-header-copying
...
On redirect, only copy headers when they don't already exist in the redirected request
2016-02-05 12:14:01 -08:00
Aaron Lehmann
c89f5b3775
Add information about manifest content types to API spec
...
Bring the spec up to date for schema2 changes.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-05 11:27:20 -08:00
Aaron Lehmann
d928dc0b92
Merge pull request #1425 from RichardScothern/fix-build
...
Correct type for repo reference
2016-02-04 17:47:03 -08:00
Richard Scothern
9894643c88
Correct type for repo reference
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-04 17:32:55 -08:00
Derek McGowan
0751bb3179
Merge pull request #1417 from RichardScothern/token-print
...
Print the correct token expiration time
2016-02-04 16:57:08 -08:00
Richard Scothern
fe0e76f322
Merge pull request #1350 from aibaars/storage-filewriter-pointer
...
Storage: remove bufferedFileWriter (dead code)
2016-02-04 16:47:52 -08:00
Richard Scothern
def3e430bb
Merge pull request #1401 from BrianBland/s3StorageClass
...
Adds "storageclass" configuration parameter for S3 driver.
2016-02-04 16:44:13 -08:00
Richard Scothern
ab6c08691e
Merge pull request #1408 from aaronlehmann/repository-interface
...
Rename Name method of Repository to Named
2016-02-04 16:43:35 -08:00
Aaron Lehmann
6158eb544d
Rename Name method of Repository to Named
...
This makes code that gets the name as a string read like
repo.Named().Name() instead of repo.Name().Name().
Requested in
https://github.com/docker/docker/pull/19887#discussion_r51479753
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-04 09:55:36 -08:00
yuzou
95b9c7281b
read the actual number of bytes according to the initial size.
...
Signed-off-by: yuzou <zouyu7@huawei.com>
2016-02-04 16:14:35 +08:00
Aaron Lehmann
bbf983c061
On redirect, only copy headers when they don't already exist in the redirected request
...
A changeset under consideration for Go 1.7 would automatically copy
headers on redirect. This change future-proofs our code so we won't make
duplicate copies of the headers if net/http does it automatically in the
future.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-03 13:19:44 -08:00
Richard Scothern
091c12f86b
Print the correct token expiration time
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-03 10:42:32 -08:00
Olivier Gambier
c4b79bda8a
Merge pull request #1410 from aaronlehmann/failured
...
Correct ErrAuthenticationFailure message
2016-02-01 19:20:35 -08:00
Aaron Lehmann
95a50c7236
Correct ErrAuthenticationFailure message
...
This was "authentication failured". Change it to "authentication
failure".
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-01 17:03:41 -08:00
Aaron Lehmann
9b395d0789
Merge pull request #1403 from dmcgowan/auth-const-keys
...
Update auth context keys to use constant
2016-02-01 16:29:07 -08:00
Aaron Lehmann
db48ad4d0f
Merge pull request #1390 from dmcgowan/token-server
...
Simple integration test token server
2016-02-01 16:27:49 -08:00
Brian Bland
a2ade36ecf
Adds test for S3 storage class configuration option
...
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-01 16:01:55 -08:00
Brian Bland
8e7910826e
Adds "storageclass" configuration parameter for S3 driver.
...
Defaults to STANDARD, also supports REDUCED_REDUNDANCY.
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-01 16:01:19 -08:00
Aaron Lehmann
6417c05a27
Merge pull request #1381 from BrianBland/s3CustomUAString
...
Adds custom registry User-Agent header to s3 HTTP requests
2016-02-01 15:40:36 -08:00
Brian Bland
f41a408e34
Adds custom registry User-Agent header to s3 HTTP requests
...
Uses docker/goamz instead of AdRoll/goamz
Adds a registry UA string param to the storage parameters when
constructing the storage driver for the registry App.
This could be used by other storage drivers as well
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-01 13:43:46 -08:00
Derek McGowan
badd8c49b6
Update auth context keys to use constant
...
Prevent using strings throughout the code to reference a string key defined in the auth package.
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-01-28 17:02:09 -08:00
Aaron Lehmann
6c135e03ce
Merge pull request #1393 from RichardScothern/putbydgst
...
Add manifest put by digest to the registry client
2016-01-28 14:41:07 -08:00
Derek McGowan
0e96574ea2
Merge pull request #1392 from aaronlehmann/client-range-requests
...
Support range requests in the client's httpReadSeeker
2016-01-28 13:44:43 -08:00
Richard Scothern
ccd11e4434
Merge pull request #1394 from RichardScothern/invalidate-bdc
...
Invalidate the blob store descriptor cache
2016-01-28 10:04:09 -08:00
Aaron Lehmann
8e571dff41
Add a CheckRedirect function to the HTTP client
...
Use it to preserve Accept and Range headers that were added to the
original request.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-27 16:11:36 -08:00
Aaron Lehmann
a58b7625ba
Support range requests in the client's httpReadSeeker
...
Remove buffering on the reader, because it's not useful. Also remove
artificial io.EOF return.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-27 16:11:36 -08:00
Richard Scothern
3e570e59f1
Invalidate the blob store descriptor caches when content is removed from from
...
the proxy. Also, switch to reference in the scheduler API.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-01-26 17:02:59 -08:00
Richard Scothern
a7740f5d0f
Correct test digest lengths and enable all unit tests
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-01-26 17:02:46 -08:00
Richard Scothern
f757372dd8
Add manifest put by digest to the registry client
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-01-26 14:20:23 -08:00
Derek McGowan
1eed0ddd07
Update token header struct to use json.RawMessage pointer
...
Since RawMessage json receivers take a pointer type, the Header structure should use points in order to call the json.RawMessage marshal and unmarshal functions
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-01-25 20:11:41 -08:00
Arthur Baars
7dee3d19d9
Storage: remove bufferedFileWriter (dead code)
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-01-23 10:30:08 +00:00
Arthur Baars
586b3d47a7
Storage: blobwriter.Write/Seek test case
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-01-23 10:30:07 +00:00
Richard Scothern
609bc63dd4
Merge pull request #1333 from aaronlehmann/use-reference-package
...
Use reference package
2016-01-22 15:54:19 -08:00
Aaron Lehmann
6149a8c634
Change URLBuilder methods to use references for tags and digests
...
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-22 14:49:29 -08:00
Aaron Lehmann
e9692b8037
Use reference package internally
...
Most places in the registry were using string types to refer to
repository names. This changes them to use reference.Named, so the type
system can enforce validation of the naming rules.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-22 14:47:05 -08:00
Aaron Lehmann
e9bcc96ad2
If the media type for a manifest is unrecognized, default to schema1
...
This is needed for compatibility with some third-party registries that
send an inappropriate Content-Type header such as text/html.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-21 09:34:06 -08:00
Stephen Day
0d46f0e786
Merge pull request #1379 from aaronlehmann/token-error
...
Handle nonstandard token endpoint errors
2016-01-20 15:07:47 -08:00
Aaron Lehmann
59254013be
Handle nonstandard token endpoint errors
...
https://github.com/docker/distribution/pull/1249 changed token fetching
to parse HTTP error response bodies as serialized errcodes. However,
Docker Hub's authentication endpoint does not return error bodies in
this format. To work around this, convert its format into
ErrCodeUnauthorized or ErrCodeUnknown.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-20 14:45:08 -08:00
Richard Scothern
05b8317291
Merge pull request #1372 from aibaars/gcs-delete
...
StorageDriver GCS: improve test suite clean-up and add retrying to all GCS api calls
2016-01-20 12:21:22 -08:00
Arthur Baars
59a9607783
StorageDriver: GCS: retry all api calls
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-01-20 13:24:09 +00:00
Arthur Baars
ffc9527782
StorageDriver: Test suite: improve cleanup
...
Verify that the file(s) have been deleted after calling Delete,
and retry if this is not the case. Furthermore, report the error
if a Delete operation fails.
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-01-20 13:24:09 +00:00
Richard Scothern
e4b654f2ce
Merge pull request #1367 from aaronlehmann/signed-manifest-content-type
...
Fix content type for schema1 signed manifests
2016-01-19 11:00:47 -08:00
Aaron Lehmann
f9a3f028b5
Fix content type for schema1 signed manifests
...
The Payload function for schema1 currently returns a signed manifest,
but indicates the content type is that of a manifest that isn't signed.
Note that this breaks compatibility with Registry 2.3 alpha 1 and
Docker 1.10-rc1, because they use the incorrect content type.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-18 16:08:02 -08:00
Richard Scothern
0640813179
Merge pull request #1363 from aaronlehmann/media-type-charset
...
Do not require "charset=utf-8" for a schema1 with content type application/json
2016-01-18 15:20:01 -08:00
Richard Scothern
b2876674f3
Merge pull request #1355 from hopkings2008/master
...
In testsuites.go, enlarge the size of randomBytes to 128M to fix the …
2016-01-18 12:38:26 -08:00
Richard Scothern
f4bd6cacd1
Merge pull request #1357 from aibaars/gcs-test
...
StorageDriver GCS test suite: try google.DefaultTokenSource first
2016-01-18 11:29:01 -08:00
Aaron Lehmann
3da0ee00d8
Do not require "charset=utf-8" for a schema1 with content type application/json
...
For compatibility with other registries that don't use this exact
variant of the Content-Type header, we need to be more flexible about
what we accept. Any form of "application/json" should be allowed. The
charset should not be included in the comparison.
See docker/docker#19400 .
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-01-18 09:59:50 -08:00
Arthur Baars
985c0d602f
StorageDriver GCS: try google.DefaultTokenSource first
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-01-15 11:47:47 +00:00
yuzou
d3d9282a30
In testsuites.go, enlarge the size of randomBytes to 128M to fix the crash of running TestConcurrentStreamReads
...
Signed-off-by: yuzou <zouyu7@huawei.com>
2016-01-15 17:22:43 +08:00
Richard Scothern
05dc6404fd
Merge pull request #1332 from RichardScothern/gcs-params
...
Change the parameters to the GCS drivers to allow CircleCI testing.
2016-01-14 15:50:09 -08:00