Aaron Lehmann
6664a1384e
Fix empty delete requests with Swift fs driver
...
The Delete method lists objects under the given path and tries to delete
all of them with a bulk delete request. If the path has no objects
underneath it, the body of this request will be empty, which causes
HTTP-level issues. Specifically, Go's HTTP client senses the empty
request buffer and doesn't include a Content-Length, which causes the
Swift server to fail the request.
This commit fixes the problem by avoiding sending empty bulk delete
requests. This is the correct thing to do anyway, since there's no
reason to request deletion of zero objects.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-11-09 15:33:05 -08:00
Ted Reed
fddbf73a57
De-obfuscate error message
...
Previously, this error message would stringify as a pointer address,
which isn't particularly helpful.
This change breaks out the elements of the challenge object such that
the error is appropriately represented.
Signed-off-by: Ted Reed <ted.reed@gmail.com>
2015-11-06 17:10:28 -08:00
Richard Scothern
362ae9cc41
Merge pull request #1156 from RichardScothern/manifest-verification
...
Manifest Verification
2015-11-04 14:09:12 -08:00
Richard Scothern
7ed02ea1db
Merge pull request #1161 from stevvooe/add-status-badges
...
Add nice status badges to README
2015-11-04 14:08:46 -08:00
Stephen J Day
5882b97ef2
Add nice status badges to README
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-11-04 12:48:18 -08:00
Richard Scothern
dd32fbe615
Before allowing a schema1 manifest to be stored in the registry, ensure that it
...
contains equal length History and FSLayer arrays.
This is required to prevent malformed manifests being put to the registry and
failing external verification checks.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-11-03 15:19:46 -08:00
Richard Scothern
603ffd58e1
Merge pull request #1150 from RichardScothern/carry-1070
...
Add Storage Driver Context.
2015-11-03 15:15:48 -08:00
Richard Scothern
bc6e4cdceb
Add a generic error type to capture non-typed errors
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-11-03 11:19:44 -08:00
amitshukla
9637cb40cd
Fix for issue 664: https://github.com/docker/distribution/issues/664
...
Errors thrown by storage drivers don't have the name of the driver, causing user
confusion about whether the error is coming from Docker or from a storage driver.
This change adds the storage driver name to each error message.
This required changing ErrUnsupportedDriver to a type, leading to code changes
whenever ErrUnsupportedDriver is used. The tests check whether the driver name
appears in the error message.
Signed-off-by: Amit Shukla <amit.shukla@docker.com>
2015-11-03 11:19:17 -08:00
Richard Scothern
a9da0e5100
Merge pull request #1114 from lebauce/swift-temp-url
...
Redirect support in Swift driver
2015-11-03 09:34:01 -08:00
Sylvain Baubeau
3ff8af326b
Ensure read after write for segments
...
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
2015-11-03 17:09:52 +01:00
Sylvain Baubeau
0737bb7175
Update Swift bindings
...
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
2015-11-03 17:09:52 +01:00
Sylvain Baubeau
7c3281861f
Add support for temporary URL for Swift driver
...
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
2015-11-03 09:59:50 +01:00
Sylvain Baubeau
7759153f2f
Update Swift bindings
...
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
2015-11-03 09:57:39 +01:00
Richard Scothern
5fc31de717
Merge pull request #1152 from RichardScothern/credit2
...
Add github IDs to maintainers
2015-11-02 17:14:35 -08:00
Richard Scothern
34754f20d8
Update authors
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-11-02 16:41:36 -08:00
Olivier Gambier
9316c2c3bc
Merge pull request #1151 from RichardScothern/credit
...
Update AUTHORS and MAINTAINERS
2015-11-02 16:07:21 -08:00
Richard Scothern
b313f011e3
Update authors
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-11-02 16:05:34 -08:00
Richard Scothern
e760111803
Update maintainers
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-11-02 16:05:06 -08:00
Richard Scothern
222e6e91c4
Merge pull request #1149 from stevvooe/close-filereader
...
registry/storage: close filereader after allocation
2015-11-02 13:22:32 -08:00
Stephen J Day
46dd057f5c
registry/storage: close filereader after allocation
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-11-02 11:55:11 -08:00
Richard Scothern
c6c9194e9c
Merge pull request #1148 from aaronlehmann/withname-check-length
...
Check length of input in WithName
2015-11-02 11:54:34 -08:00
Aaron Lehmann
073bd89262
Check length of input in WithName
...
There is a constraint on the length of the name in a reference, so
WithName should be checking this instead of potentially creating a
reference that doesn't comply with the rules.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-11-02 09:12:21 -08:00
Richard Scothern
ef17db8d73
Merge pull request #1122 from RichardScothern/scheduler-coalesce
...
Buffer writes to scheduler state file.
2015-10-30 13:43:07 -07:00
Richard Scothern
326ec6c121
Merge pull request #1139 from aaronlehmann/reference-withtag-fix
...
Use correct regexp in reference.WithTag
2015-10-29 15:25:18 -07:00
Richard Scothern
33428c37e1
Buffer writing the scheduler entry state to disk by periodically checking for
...
changes to the entries index and saving it to the filesystem.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-10-29 11:35:52 -07:00
Richard Scothern
9e8aaf7b40
Merge pull request #756 from aibaars/storage-gcs
...
Storage driver for Google Cloud Storage
2015-10-29 10:41:17 -07:00
Aaron Lehmann
985ee759e7
Use correct regexp in reference.WithTag
...
This was using a different regexp from the intended one. This meant that
tags with uppercase characters were not accepted.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-10-28 18:22:00 -07:00
Richard Scothern
987a69dd05
Merge pull request #1096 from aaronlehmann/simplify-proxy-scheduler
...
Simplify proxy scheduler
2015-10-28 13:23:00 -07:00
Arthur Baars
59784ecdd0
Storage driver for: Google Cloud Storage (gcs)
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2015-10-28 20:21:56 +00:00
Arthur Baars
41e71e9a46
Google Cloud Storage (gcs) dependencies (2)
...
Add files of new dependencies to Godeps/_workspace
Signed-off-by: Arthur Baars <arthur@semmle.com>
2015-10-28 11:26:43 +00:00
Arthur Baars
95db61e97f
Google Cloud Storage (gcs) dependencies (1)
...
Add new dependencies to Godeps/Godeps.json
Signed-off-by: Arthur Baars <arthur@semmle.com>
2015-10-28 11:26:39 +00:00
Olivier Gambier
731c43e3db
Merge pull request #1136 from RichardScothern/update-roadmap
...
Update distribution roadmap.
2015-10-27 20:39:52 -07:00
Richard Scothern
183d144520
Update distribution roadmap.
...
Update pull through cache status.
Add section for metadata storage.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-10-27 17:20:49 -07:00
Stephen Day
2d23e77284
Merge pull request #1047 from mattmoor/expires_in_proposal
...
Add `expires_in` and `issued_at` to the auth spec.
2015-10-27 14:29:08 -07:00
Stephen Day
6bcd8a1dec
Merge pull request #1099 from RichardScothern/go-version
...
Add go version to logger output
2015-10-27 14:19:43 -07:00
Matt Moore
0c7cd3fcf8
Add expires_in
and issued_at
to the auth spec.
...
This extends the specification for the Bearer token response to include
information pertaining to when an issued Bearer token will expire.
This also allows the client to accept `access_token` as an alias for `token`.
Signed-off-by: Matt Moore <mattmoor@google.com>
2015-10-27 11:05:33 -07:00
Rusty Conover
5f2205981b
Fix failing test case
...
When building a URL don't include path components in the host parameter.
Closes #1124
Signed-off-by: Rusty Conover <rusty@luckydinosaur.com>
2015-10-25 13:03:22 -04:00
Richard Scothern
1c5f8166e4
Merge pull request #1121 from thaJeztah/fix-doc-emoji
...
Docs: replace emoji with regular warning
2015-10-22 17:13:33 -07:00
Sebastiaan van Stijn
bf6ca6cb53
Docs: replace emoji with regular warning
...
The docs don't render emoji, so replaced the `⚠️ ` with
a `**Warning**:` to keep the formatting consisten with
`**Note**:` used in other parts of the docs.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2015-10-22 15:59:48 -07:00
Richard Scothern
a266f99418
Merge pull request #1095 from mrwacky42/api-version-annotated
...
Add annotated example for adding header; +spelling
2015-10-22 14:04:32 -07:00
Richard Scothern
e569236f1e
Add go version to logger output
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-10-22 10:11:25 -07:00
Olivier Gambier
24a3f92616
Merge pull request #1118 from SvenDowideit/stop-linking-when-rendering-to-html
...
Prevent md->html link generation
2015-10-22 09:34:09 -07:00
Sven Dowideit
a5040860f2
Prevent md->html link generation
...
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
2015-10-22 17:27:21 +10:00
Stephen Day
e5d9837970
Merge pull request #1098 from denverdino/master
...
Redundant digest verification in validateBlob when pushing a new layer
2015-10-21 14:50:18 -07:00
Stephen Day
e6bb0aa7c0
Merge pull request #1115 from tianon/fix-auth-servehttp-comment
...
Update "type auth.Challenge" comment example code
2015-10-21 12:56:14 -07:00
Tianon Gravi
39d47e8eea
Update "type auth.Challenge" comment example code
...
This interface was changed in a0fdfb9d4d
, but the comment wasn't ever updated to match.
Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>
2015-10-21 11:54:13 -07:00
Richard Scothern
7e9c832524
Merge pull request #1111 from aaronlehmann/golint-comments
...
Correct two golint comment issues
2015-10-20 09:53:14 -07:00
Aaron Lehmann
5608db616c
Correct two golint comment issues
...
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-10-19 16:42:12 -07:00
Olivier Gambier
21b6f54796
Merge pull request #1110 from RichardScothern/env-var-clarification
...
Clearer documentation around environment variable overrides
2015-10-19 14:53:20 -07:00