distribution/registry/storage/driver/s3-aws
Aaron Lehmann 2074688be9 Fix S3 multipart upload pagination loop condition
The loop that iterates over paginated lists of S3 multipart upload parts
appears to be using the wrong variable in its loop condition. Nothing
inside the loop affects the value of `resp.IsTruncated`, so this loop
will either be wrongly skipped or loop forever.

It looks like this is a regression caused by commit
7736319f2e. The return value of
`ListMultipartUploads` used to be assigned to a variable named `resp`,
but it was renamed to `partsList` without updating the for loop
condition.

I believe this is causing an error we're seeing with large layer uploads
at commit time:

    upload resumed at wrong offset: 5242880000 != 5815706782

Missing parts of the multipart S3 upload would cause an incorrect size
calculation in `newWriter`.

Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2023-02-21 20:57:50 -08:00
..
s3.go Fix S3 multipart upload pagination loop condition 2023-02-21 20:57:50 -08:00
s3_test.go replace deprecated io/ioutil 2022-11-04 23:47:52 +01:00
s3_v2_signer.go Fix gometalint errors 2019-02-04 16:01:04 -08:00