b23dd1ef37
When uploading segments to Swift, the registry generates a random file, by taking the hash of the container path and 32-bytes of random data. The registry attempts to shard across multiple directory paths, by taking the first three hex characters as leader. The implementation in registry, unfortunately, takes the hash of nothing, and appends it to the path and random data. This results in all segments being created in one directory. Fixes: #2407 Fixes: #2311 Signed-off-by: Terin Stock <terinjokes@gmail.com>
281 lines
6.6 KiB
Go
281 lines
6.6 KiB
Go
package swift
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"reflect"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/ncw/swift/swifttest"
|
|
|
|
"github.com/docker/distribution/context"
|
|
storagedriver "github.com/docker/distribution/registry/storage/driver"
|
|
"github.com/docker/distribution/registry/storage/driver/testsuites"
|
|
|
|
"gopkg.in/check.v1"
|
|
)
|
|
|
|
// Hook up gocheck into the "go test" runner.
|
|
func Test(t *testing.T) { check.TestingT(t) }
|
|
|
|
var swiftDriverConstructor func(prefix string) (*Driver, error)
|
|
|
|
func init() {
|
|
var (
|
|
username string
|
|
password string
|
|
authURL string
|
|
tenant string
|
|
tenantID string
|
|
domain string
|
|
domainID string
|
|
tenantDomain string
|
|
tenantDomainID string
|
|
trustID string
|
|
container string
|
|
region string
|
|
AuthVersion int
|
|
endpointType string
|
|
insecureSkipVerify bool
|
|
secretKey string
|
|
accessKey string
|
|
containerKey bool
|
|
tempURLMethods []string
|
|
|
|
swiftServer *swifttest.SwiftServer
|
|
err error
|
|
)
|
|
username = os.Getenv("SWIFT_USERNAME")
|
|
password = os.Getenv("SWIFT_PASSWORD")
|
|
authURL = os.Getenv("SWIFT_AUTH_URL")
|
|
tenant = os.Getenv("SWIFT_TENANT_NAME")
|
|
tenantID = os.Getenv("SWIFT_TENANT_ID")
|
|
domain = os.Getenv("SWIFT_DOMAIN_NAME")
|
|
domainID = os.Getenv("SWIFT_DOMAIN_ID")
|
|
tenantDomain = os.Getenv("SWIFT_DOMAIN_NAME")
|
|
tenantDomainID = os.Getenv("SWIFT_DOMAIN_ID")
|
|
trustID = os.Getenv("SWIFT_TRUST_ID")
|
|
container = os.Getenv("SWIFT_CONTAINER_NAME")
|
|
region = os.Getenv("SWIFT_REGION_NAME")
|
|
AuthVersion, _ = strconv.Atoi(os.Getenv("SWIFT_AUTH_VERSION"))
|
|
endpointType = os.Getenv("SWIFT_ENDPOINT_TYPE")
|
|
insecureSkipVerify, _ = strconv.ParseBool(os.Getenv("SWIFT_INSECURESKIPVERIFY"))
|
|
secretKey = os.Getenv("SWIFT_SECRET_KEY")
|
|
accessKey = os.Getenv("SWIFT_ACCESS_KEY")
|
|
containerKey, _ = strconv.ParseBool(os.Getenv("SWIFT_TEMPURL_CONTAINERKEY"))
|
|
tempURLMethods = strings.Split(os.Getenv("SWIFT_TEMPURL_METHODS"), ",")
|
|
|
|
if username == "" || password == "" || authURL == "" || container == "" {
|
|
if swiftServer, err = swifttest.NewSwiftServer("localhost"); err != nil {
|
|
panic(err)
|
|
}
|
|
username = "swifttest"
|
|
password = "swifttest"
|
|
authURL = swiftServer.AuthURL
|
|
container = "test"
|
|
}
|
|
|
|
prefix, err := ioutil.TempDir("", "driver-")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
defer os.Remove(prefix)
|
|
|
|
swiftDriverConstructor = func(root string) (*Driver, error) {
|
|
parameters := Parameters{
|
|
username,
|
|
password,
|
|
authURL,
|
|
tenant,
|
|
tenantID,
|
|
domain,
|
|
domainID,
|
|
tenantDomain,
|
|
tenantDomainID,
|
|
trustID,
|
|
region,
|
|
AuthVersion,
|
|
container,
|
|
root,
|
|
endpointType,
|
|
insecureSkipVerify,
|
|
defaultChunkSize,
|
|
secretKey,
|
|
accessKey,
|
|
containerKey,
|
|
tempURLMethods,
|
|
}
|
|
|
|
return New(parameters)
|
|
}
|
|
|
|
driverConstructor := func() (storagedriver.StorageDriver, error) {
|
|
return swiftDriverConstructor(prefix)
|
|
}
|
|
|
|
testsuites.RegisterSuite(driverConstructor, testsuites.NeverSkip)
|
|
}
|
|
|
|
func TestEmptyRootList(t *testing.T) {
|
|
validRoot, err := ioutil.TempDir("", "driver-")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating temporary directory: %v", err)
|
|
}
|
|
defer os.Remove(validRoot)
|
|
|
|
rootedDriver, err := swiftDriverConstructor(validRoot)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating rooted driver: %v", err)
|
|
}
|
|
|
|
emptyRootDriver, err := swiftDriverConstructor("")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating empty root driver: %v", err)
|
|
}
|
|
|
|
slashRootDriver, err := swiftDriverConstructor("/")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating slash root driver: %v", err)
|
|
}
|
|
|
|
filename := "/test"
|
|
contents := []byte("contents")
|
|
ctx := context.Background()
|
|
err = rootedDriver.PutContent(ctx, filename, contents)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating content: %v", err)
|
|
}
|
|
|
|
keys, _ := emptyRootDriver.List(ctx, "/")
|
|
for _, path := range keys {
|
|
if !storagedriver.PathRegexp.MatchString(path) {
|
|
t.Fatalf("unexpected string in path: %q != %q", path, storagedriver.PathRegexp)
|
|
}
|
|
}
|
|
|
|
keys, _ = slashRootDriver.List(ctx, "/")
|
|
for _, path := range keys {
|
|
if !storagedriver.PathRegexp.MatchString(path) {
|
|
t.Fatalf("unexpected string in path: %q != %q", path, storagedriver.PathRegexp)
|
|
}
|
|
}
|
|
|
|
// Create an object with a path nested under the existing object
|
|
err = rootedDriver.PutContent(ctx, filename+"/file1", contents)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error creating content: %v", err)
|
|
}
|
|
|
|
err = rootedDriver.Delete(ctx, filename)
|
|
if err != nil {
|
|
t.Fatalf("failed to delete: %v", err)
|
|
}
|
|
|
|
keys, err = rootedDriver.List(ctx, "/")
|
|
if err != nil {
|
|
t.Fatalf("failed to list objects after deletion: %v", err)
|
|
}
|
|
|
|
if len(keys) != 0 {
|
|
t.Fatal("delete did not remove nested objects")
|
|
}
|
|
}
|
|
|
|
func TestFilenameChunking(t *testing.T) {
|
|
// Test valid input and sizes
|
|
input := []string{"a", "b", "c", "d", "e"}
|
|
expecteds := [][][]string{
|
|
{
|
|
{"a"},
|
|
{"b"},
|
|
{"c"},
|
|
{"d"},
|
|
{"e"},
|
|
},
|
|
{
|
|
{"a", "b"},
|
|
{"c", "d"},
|
|
{"e"},
|
|
},
|
|
{
|
|
{"a", "b", "c"},
|
|
{"d", "e"},
|
|
},
|
|
{
|
|
{"a", "b", "c", "d"},
|
|
{"e"},
|
|
},
|
|
{
|
|
{"a", "b", "c", "d", "e"},
|
|
},
|
|
{
|
|
{"a", "b", "c", "d", "e"},
|
|
},
|
|
}
|
|
for i, expected := range expecteds {
|
|
actual, err := chunkFilenames(input, i+1)
|
|
if !reflect.DeepEqual(actual, expected) {
|
|
t.Fatalf("chunk %v didn't match expected value %v", actual, expected)
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("unexpected error chunking filenames: %v", err)
|
|
}
|
|
}
|
|
|
|
// Test nil input
|
|
actual, err := chunkFilenames(nil, 5)
|
|
if len(actual) != 0 {
|
|
t.Fatal("chunks were returned when passed nil")
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("unexpected error chunking filenames: %v", err)
|
|
}
|
|
|
|
// Test 0 and < 0 sizes
|
|
_, err = chunkFilenames(nil, 0)
|
|
if err == nil {
|
|
t.Fatal("expected error for size = 0")
|
|
}
|
|
_, err = chunkFilenames(nil, -1)
|
|
if err == nil {
|
|
t.Fatal("expected error for size = -1")
|
|
}
|
|
}
|
|
|
|
func TestSwiftSegmentPath(t *testing.T) {
|
|
d := &driver{
|
|
Prefix: "/test/segment/path",
|
|
}
|
|
|
|
s1, err := d.swiftSegmentPath("foo-baz")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error generating segment path: %v", err)
|
|
}
|
|
|
|
s2, err := d.swiftSegmentPath("foo-baz")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error generating segment path: %v", err)
|
|
}
|
|
|
|
if !strings.HasPrefix(s1, "test/segment/path/segments/") {
|
|
t.Fatalf("expected to be prefixed: %s", s1)
|
|
}
|
|
|
|
if !strings.HasPrefix(s1, "test/segment/path/segments/") {
|
|
t.Fatalf("expected to be prefixed: %s", s2)
|
|
}
|
|
|
|
if len(s1) != 68 {
|
|
t.Fatalf("unexpected segment path length, %d != %d", len(s1), 68)
|
|
}
|
|
|
|
if len(s2) != 68 {
|
|
t.Fatalf("unexpected segment path length, %d != %d", len(s2), 68)
|
|
}
|
|
|
|
if s1 == s2 {
|
|
t.Fatalf("expected segment paths to differ, %s == %s", s1, s2)
|
|
}
|
|
}
|