15b0204758
This fixes registry endpoints to return the proper `application/json` content-type for JSON content, also updating spec examples for that. As per IETF specification and IANA registry [0], the `application/json` type is a binary media, so the content-type label does not need any text-charset selector. Additionally, the media type definition explicitly states that it has no required nor optional parameters, which makes the current registry headers non-compliant. [0]: https://www.iana.org/assignments/media-types/application/json Signed-off-by: Luca Bruno <lucab@debian.org>
62 lines
1.5 KiB
Go
62 lines
1.5 KiB
Go
package handlers
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
|
|
"github.com/docker/distribution"
|
|
"github.com/docker/distribution/registry/api/errcode"
|
|
"github.com/docker/distribution/registry/api/v2"
|
|
"github.com/gorilla/handlers"
|
|
)
|
|
|
|
// tagsDispatcher constructs the tags handler api endpoint.
|
|
func tagsDispatcher(ctx *Context, r *http.Request) http.Handler {
|
|
tagsHandler := &tagsHandler{
|
|
Context: ctx,
|
|
}
|
|
|
|
return handlers.MethodHandler{
|
|
"GET": http.HandlerFunc(tagsHandler.GetTags),
|
|
}
|
|
}
|
|
|
|
// tagsHandler handles requests for lists of tags under a repository name.
|
|
type tagsHandler struct {
|
|
*Context
|
|
}
|
|
|
|
type tagsAPIResponse struct {
|
|
Name string `json:"name"`
|
|
Tags []string `json:"tags"`
|
|
}
|
|
|
|
// GetTags returns a json list of tags for a specific image name.
|
|
func (th *tagsHandler) GetTags(w http.ResponseWriter, r *http.Request) {
|
|
defer r.Body.Close()
|
|
|
|
tagService := th.Repository.Tags(th)
|
|
tags, err := tagService.All(th)
|
|
if err != nil {
|
|
switch err := err.(type) {
|
|
case distribution.ErrRepositoryUnknown:
|
|
th.Errors = append(th.Errors, v2.ErrorCodeNameUnknown.WithDetail(map[string]string{"name": th.Repository.Named().Name()}))
|
|
case errcode.Error:
|
|
th.Errors = append(th.Errors, err)
|
|
default:
|
|
th.Errors = append(th.Errors, errcode.ErrorCodeUnknown.WithDetail(err))
|
|
}
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
|
|
enc := json.NewEncoder(w)
|
|
if err := enc.Encode(tagsAPIResponse{
|
|
Name: th.Repository.Named().Name(),
|
|
Tags: tags,
|
|
}); err != nil {
|
|
th.Errors = append(th.Errors, errcode.ErrorCodeUnknown.WithDetail(err))
|
|
return
|
|
}
|
|
}
|