distribution/reference
Sebastiaan van Stijn 6d4f62d7fd
reference: remove support for deprecated "shortid" refs
The "shortid" syntax was added in d26a3b37a6,
and allowed for matching an image on its ID prefix (this is before images were
content-addressable). With the introduction of content-addressable references,
this syntax became problematic, and Docker deprecated this syntax in 2016
(Docker v1.13.0) through commit; 5fc71599a0

> The `repository:shortid` syntax for referencing images is very little used,
> collides with tag references, and can be confused with digest references.

Support for this syntax was removed in 2017 (Docker 17.12) through commit:
a942c92dd7

containerd uses a fork of the reference package with this syntax removed, and
does not support this syntax:
901bcb2231

This patch removes the deprecated syntax, the ParseAnyReferenceWithSet function,
and the ShortIdentifierRegexp regex.

As there are no external consumers for this function, nor the regexp, I'm
skipping a deprecation cycle for this;

- https://grep.app/search?q=.ShortIdentifierRegexp
- https://grep.app/search?q=.ParseAnyReferenceWithSet%28

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-11-06 20:23:30 +01:00
..
fuzz.go format code with gofumpt 2022-11-03 22:48:20 +01:00
helpers.go Merge pull request #2143 from dmcgowan/reference-familiar-match 2017-01-13 18:32:33 -08:00
normalize.go reference: remove support for deprecated "shortid" refs 2022-11-06 20:23:30 +01:00
normalize_test.go reference: remove support for deprecated "shortid" refs 2022-11-06 20:23:30 +01:00
reference.go format code with gofumpt 2022-11-03 22:48:20 +01:00
reference_test.go registry: support ipv6 addresses 2022-06-27 09:54:37 +02:00
regexp.go reference: remove support for deprecated "shortid" refs 2022-11-06 20:23:30 +01:00
regexp_test.go reference: remove support for deprecated "shortid" refs 2022-11-06 20:23:30 +01:00