TrueCloudLab/frostfs-api-go
22
0
Fork 15
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

[#199] sdk: Refactor string parse errors

Browse source 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2020-11-16 16:33:41 +03:00 • committed by Alex Vanin
parent fe336fd5ba
commit 79f72e10c9
9 changed files with 15 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pkg/object/id.go
View file

@ -5,7 +5,6 @@ import (
"crypto/sha256"
"github.com/mr-tron/base58"
"github.com/nspcc-dev/neofs-api-go/internal"
"github.com/nspcc-dev/neofs-api-go/v2/refs"
"github.com/pkg/errors"
)
@ -13,9 +12,7 @@ import (
// ID represents v2-compatible object identifier.
type ID refs.ObjectID
// ErrBadID should be returned when bytes slice hasn't sha256.Size
// Notice: if byte slice changed, please, replace error message.
const ErrBadID = internal.Error("object.ID should be 32 bytes length")
var errInvalidIDString = errors.New("incorrect format of the string object ID")
// NewIDFromV2 wraps v2 ObjectID message to ID.
func NewIDFromV2(idV2 *refs.ObjectID) *ID {
@ -53,7 +50,7 @@ func (id *ID) Parse(s string) error {
if err != nil {
return errors.Wrap(err, "could not parse object.ID from string")
} else if len(data) != sha256.Size {
return ErrBadID
return errInvalidIDString
}
(*refs.ObjectID)(id).SetValue(data)