TrueCloudLab/frostfs-api-go
22
0
Fork 15
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

Rename unified client constructors

Browse source 
Client constructor `New` will be used as `package.New()`
in external packages. This definition is not very clear
since it can create new structure or new client or whatever.
`package.NewClient()` is quite unambiguous.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
Alex Vanin 2020-08-24 10:17:03 +03:00 • committed by Stanislav Bogatyrev
parent 55a6509e8f
commit 86d56086e3
8 changed files with 37 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

18
v2/object/test/client_test.go
View file

@ -274,7 +274,7 @@ func TestGRPCClient_Head(t *testing.T) {
server: srv,
}
c, err := object.New(object.WithGRPCServiceClient(cli))
c, err := object.NewClient(object.WithGRPCServiceClient(cli))
require.NoError(t, err)
resp, err := c.Head(ctx, new(object.HeadRequest))
@ -287,7 +287,7 @@ func TestGRPCClient_Head(t *testing.T) {
require.Error(t, signature.VerifyServiceMessage(req))
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: new(testGRPCServer),
@ -308,7 +308,7 @@ func TestGRPCClient_Head(t *testing.T) {
resp := testHeadResponse()
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: &testGRPCServer{
@ -346,7 +346,7 @@ func TestGRPCClient_Delete(t *testing.T) {
server: srv,
}
c, err := object.New(object.WithGRPCServiceClient(cli))
c, err := object.NewClient(object.WithGRPCServiceClient(cli))
require.NoError(t, err)
resp, err := c.Delete(ctx, new(object.DeleteRequest))
@ -359,7 +359,7 @@ func TestGRPCClient_Delete(t *testing.T) {
require.Error(t, signature.VerifyServiceMessage(req))
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: new(testGRPCServer),
@ -380,7 +380,7 @@ func TestGRPCClient_Delete(t *testing.T) {
resp := testDeleteResponse()
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: &testGRPCServer{
@ -418,7 +418,7 @@ func TestGRPCClient_GetRangeHash(t *testing.T) {
server: srv,
}
c, err := object.New(object.WithGRPCServiceClient(cli))
c, err := object.NewClient(object.WithGRPCServiceClient(cli))
require.NoError(t, err)
resp, err := c.GetRangeHash(ctx, new(object.GetRangeHashRequest))
@ -431,7 +431,7 @@ func TestGRPCClient_GetRangeHash(t *testing.T) {
require.Error(t, signature.VerifyServiceMessage(req))
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: new(testGRPCServer),
@ -452,7 +452,7 @@ func TestGRPCClient_GetRangeHash(t *testing.T) {
resp := testGetRangeHashResponse()
c, err := object.New(
c, err := object.NewClient(
object.WithGRPCServiceClient(
&testGRPCClient{
server: &testGRPCServer{