TrueCloudLab/frostfs-api-go

Author	SHA1	Message	Date
Evgenii Stratonikov	f0fc40e116	[#123 ] Resolve funlen linter issue All checks were successful DCO action / DCO (pull_request) Successful in 55s Details Tests and linters / Tests with -race (pull_request) Successful in 1m8s Details Tests and linters / Tests (pull_request) Successful in 1m31s Details Tests and linters / Lint (pull_request) Successful in 1m58s Details Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-11 14:40:54 +03:00
Evgenii Stratonikov	29f2157563	[#123 ] protogen: Treat bytes field as non-nullable In protobuf 3.12 they have added an support for `optional` keyword, which has made it into the main branch in 3.15. https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis This means that without an explicit `optional` keyword field presence for scalars is not tracked, thus empty string in JSON should be unmarshaled to a nil byte slice. Relevant decoding code and tests from protojson: `fb995f184a/internal/impl/message_reflect_field.go (L327)` `fb995f184a/encoding/protojson/decode_test.go (L134)` `fb995f184a/encoding/protojson/decode_test.go (L156)` We do not support `optional` keyword and the generator will fail if it sees on. So only implement the default behaviour. Refs #122 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-11 14:40:54 +03:00
Evgenii Stratonikov	29c522d5d8	[#122 ] protogen: Always marshal empty fields All checks were successful DCO action / DCO (pull_request) Successful in 1m2s Details Tests and linters / Lint (pull_request) Successful in 1m2s Details Tests and linters / Tests (pull_request) Successful in 1m16s Details Tests and linters / Tests with -race (pull_request) Successful in 1m16s Details This is how it was done previously: `a0a9b765f3/rpc/message/encoding.go (L31)` The tricky part is `[]byte` which is marshaled as `null` by easyjson helper, but as `""` by protojson. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-07 15:05:43 +03:00
Evgenii Stratonikov	b06dad731c	[#120 ] protogen: Marshal 64-bit integers as strings Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-01 14:18:46 +03:00
Evgenii Stratonikov	d94b9c6d0d	[#120 ] protogen: Unmarshal stringified integers from JSON Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-01 14:18:45 +03:00
Evgenii Stratonikov	eeb754c327	[#120 ] protogen: Omit empty fields from JSON output Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-01 14:11:43 +03:00
Evgenii Stratonikov	805da79319	[#120 ] protogen: Marshal enum as string Be compatible with protojson. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-01 14:11:43 +03:00
Evgenii Stratonikov	5e1c6a908f	[#111 ] protogen: Emit slice of messages without a pointer All checks were successful DCO action / DCO (pull_request) Successful in 41s Details Tests and linters / Tests (1.22) (pull_request) Successful in 55s Details Tests and linters / Tests (1.23) (pull_request) Successful in 57s Details Tests and linters / Tests with -race (pull_request) Successful in 1m8s Details Tests and linters / Lint (pull_request) Successful in 2m12s Details ``` goos: linux goarch: amd64 pkg: git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/refs cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz │ old │ new │ │ sec/op │ sec/op vs base │ ObjectIDSlice/0_elements/to_grpc_message-8 3.193n ± 2% 3.242n ± 0% +1.50% (p=0.034 n=10) ObjectIDSlice/0_elements/from_grpc_message-8 3.197n ± 2% 3.343n ± 1% +4.57% (p=0.000 n=10) ObjectIDSlice/0_elements/marshal-8 5.666n ± 3% 5.642n ± 0% -0.42% (p=0.000 n=10) ObjectIDSlice/1_elements/to_grpc_message-8 53.10n ± 6% 29.78n ± 12% -43.92% (p=0.000 n=10) ObjectIDSlice/1_elements/from_grpc_message-8 28.99n ± 5% 29.77n ± 7% ~ (p=0.165 n=10) ObjectIDSlice/1_elements/marshal-8 49.08n ± 7% 50.72n ± 6% ~ (p=0.218 n=10) ObjectIDSlice/50_elements/to_grpc_message-8 1652.5n ± 7% 277.2n ± 1% -83.22% (p=0.000 n=10) ObjectIDSlice/50_elements/from_grpc_message-8 261.2n ± 11% 226.7n ± 15% -13.19% (p=0.003 n=10) ObjectIDSlice/50_elements/marshal-8 1.512µ ± 6% 1.514µ ± 6% ~ (p=0.955 n=10) geomean 52.15n 39.99n -23.31% │ old │ new │ │ B/op │ B/op vs base │ ObjectIDSlice/0_elements/to_grpc_message-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/0_elements/from_grpc_message-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/0_elements/marshal-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/1_elements/to_grpc_message-8 32.00 ± 0% 24.00 ± 0% -25.00% (p=0.000 n=10) ObjectIDSlice/1_elements/from_grpc_message-8 24.00 ± 0% 24.00 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/1_elements/marshal-8 48.00 ± 0% 48.00 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/50_elements/to_grpc_message-8 1.578Ki ± 0% 1.250Ki ± 0% -20.79% (p=0.000 n=10) ObjectIDSlice/50_elements/from_grpc_message-8 1.250Ki ± 0% 1.250Ki ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/50_elements/marshal-8 2.000Ki ± 0% 2.000Ki ± 0% ~ (p=1.000 n=10) ¹ geomean ² -5.62% ² ¹ all samples are equal ² summaries must be >0 to compute geomean │ old │ new │ │ allocs/op │ allocs/op vs base │ ObjectIDSlice/0_elements/to_grpc_message-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/0_elements/from_grpc_message-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/0_elements/marshal-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/1_elements/to_grpc_message-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10) ObjectIDSlice/1_elements/from_grpc_message-8 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/1_elements/marshal-8 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/50_elements/to_grpc_message-8 51.000 ± 0% 1.000 ± 0% -98.04% (p=0.000 n=10) ObjectIDSlice/50_elements/from_grpc_message-8 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹ ObjectIDSlice/50_elements/marshal-8 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹ geomean ² -40.18% ² ¹ all samples are equal ² summaries must be >0 to compute geomean ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-28 11:53:08 +03:00
Evgenii Stratonikov	5fece80b42	[#108 ] protogen: Distinguish between empty and nil messages All checks were successful DCO action / DCO (pull_request) Successful in 39s Details Tests and linters / Tests (1.22) (pull_request) Successful in 59s Details Tests and linters / Tests (1.23) (pull_request) Successful in 57s Details Tests and linters / Tests with -race (pull_request) Successful in 1m9s Details Tests and linters / Lint (pull_request) Successful in 2m12s Details Refs #59 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-27 11:02:18 +03:00
Evgenii Stratonikov	866db105ed	[#107 ] protogen: Unify oneof getters with default protoc plugin Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-26 14:36:19 +03:00
Evgenii Stratonikov	937a53683a	[#107 ] protogen: Fix oneof JSON marshaling Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-26 14:36:19 +03:00
Evgenii Stratonikov	4a00ef946f	[#107 ] protogen: Fix oneof getter scalar default value Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-26 14:36:19 +03:00
Evgenii Stratonikov	c1b5f46f98	[#107 ] protogen: Remove unused parameter Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-26 14:36:19 +03:00
Evgenii Stratonikov	adb7c602d7	[#77 ] protogen: Initial implementation Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-19 10:47:00 +03:00
Evgenii Stratonikov	19247e8941	[#103 ] protogen: Handle uint32 type Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-09 11:18:17 +03:00
Evgenii Stratonikov	ff4f31b6f3	[#103 ] protogen: Handle files in all packages Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-08-09 11:18:17 +03:00
Evgenii Stratonikov	f517e39491	[#91 ] protogen: Support unpacked repeated uint64 fields All checks were successful DCO action / DCO (pull_request) Successful in 1m18s Details Tests and linters / Lint (pull_request) Successful in 1m31s Details Tests and linters / Tests (1.20) (pull_request) Successful in 1m39s Details Tests and linters / Tests (1.19) (pull_request) Successful in 1m45s Details Tests and linters / Tests with -race (pull_request) Successful in 2m21s Details Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-07-16 14:39:20 +03:00
Evgenii Stratonikov	a85146250b	[#68 ] Makefile: Use gofumpt for formatting All checks were successful DCO action / DCO (pull_request) Successful in 1m17s Details Tests and linters / Tests (1.20) (pull_request) Successful in 2m22s Details Tests and linters / Lint (pull_request) Successful in 2m51s Details Tests and linters / Tests (1.19) (pull_request) Successful in 2m48s Details Tests and linters / Tests with -race (pull_request) Successful in 2m40s Details Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-03-14 10:31:58 +03:00
Evgenii Stratonikov	3072090c77	[#51 ] protogen: Do not panic in StableSize() All checks were successful Tests and linters / Lint (pull_request) Successful in 1m56s Details Tests and linters / Tests (1.20) (pull_request) Successful in 1m7s Details Tests and linters / Tests (1.19) (pull_request) Successful in 2m37s Details Tests and linters / Tests with -race (pull_request) Successful in 1m44s Details Refs TrueCloudLab/frostfs-node#554 . Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2023-08-02 10:47:14 +03:00
Alex Vanin	f69d2ad83c	Rename package name Due to source code relocation from GitHub. Signed-off-by: Alex Vanin <a.vanin@yadro.com>	2023-03-07 13:42:36 +03:00
Evgenii Stratonikov	1351b6656d	Move to frostfs-api Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2022-12-12 17:40:48 +03:00
Evgenii Stratonikov	454b5c0ed7	[#406 ] protogen: Uncomment control service line Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>	2022-06-20 14:45:58 +03:00
fyrchik	0b8e4e4753	[#400 ] Support latest API in protoc plugin (#400 ) Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>	2022-05-30 10:33:01 +03:00
Evgenii Stratonikov	23702bc51a	util/protogen: add `StableMarshal` generator command Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>	2022-04-21 15:07:57 +03:00

24 commits