frostfs-api-go

TrueCloudLab/frostfs-api-go

Fork 15

Author SHA1 Message Date

Author	SHA1	Message	Date
Evgenii Stratonikov	fdf56fabe5	[#123 ] protogen: Treat bytes field as non-nullable Some checks failed Tests and linters / Lint (pull_request) Failing after 38s Details DCO action / DCO (pull_request) Successful in 1m12s Details Tests and linters / Tests (pull_request) Successful in 1m38s Details Tests and linters / Tests with -race (pull_request) Successful in 1m39s Details In protobuf 3.12 they have added an support for `optional` keyword, which has made it into the main branch in 3.15. https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis This means that without an explicit `optional` keyword field presence for scalars is not tracked, thus empty string in JSON should be unmarshaled to a nil byte slice. Relevant decoding code and tests from protojson: `fb995f184a/internal/impl/message_reflect_field.go (L327)` `fb995f184a/encoding/protojson/decode_test.go (L134)` `fb995f184a/encoding/protojson/decode_test.go (L156)` We do not support `optional` keyword and the generator will fail if it sees on. So only implement the default behaviour. Refs #122 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-11 10:21:17 +03:00

Evgenii Stratonikov

fdf56fabe5

[#123 ] protogen: Treat bytes field as non-nullable

Tests and linters / Lint (pull_request) Failing after 38s

Details

DCO action / DCO (pull_request) Successful in 1m12s

Details

Tests and linters / Tests (pull_request) Successful in 1m38s

Details

Tests and linters / Tests with -race (pull_request) Successful in 1m39s

Details

In protobuf 3.12 they have added an support for `optional` keyword,
which has made it into the main branch in 3.15.
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md
https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis

This means that without an explicit `optional` keyword field presence
for scalars is not tracked, thus empty string in JSON should be
unmarshaled to a nil byte slice. Relevant decoding code and tests from
protojson:
fb995f184a/internal/impl/message_reflect_field.go (L327)
fb995f184a/encoding/protojson/decode_test.go (L134)
fb995f184a/encoding/protojson/decode_test.go (L156)

We do not support `optional` keyword and the generator will fail if it sees on.
So only implement the default behaviour.

Refs #122

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

2024-10-11 10:21:17 +03:00

Compare commits

1 commit

7aebd82a84 ... fdf56fabe5

Diff content is not available

Compare commits

1 commit 7aebd82a84 ... fdf56fabe5

Diff content is not available

1 commit

7aebd82a84 ... fdf56fabe5