frostfs-api-go

TrueCloudLab/frostfs-api-go

Fork 15

Author SHA1 Message Date

Author	SHA1	Message	Date
Evgenii Stratonikov	f0fc40e116	[#123 ] Resolve funlen linter issue All checks were successful DCO action / DCO (pull_request) Successful in 55s Details Tests and linters / Tests with -race (pull_request) Successful in 1m8s Details Tests and linters / Tests (pull_request) Successful in 1m31s Details Tests and linters / Lint (pull_request) Successful in 1m58s Details Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-11 14:40:54 +03:00
Evgenii Stratonikov	29f2157563	[#123 ] protogen: Treat bytes field as non-nullable In protobuf 3.12 they have added an support for `optional` keyword, which has made it into the main branch in 3.15. https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis This means that without an explicit `optional` keyword field presence for scalars is not tracked, thus empty string in JSON should be unmarshaled to a nil byte slice. Relevant decoding code and tests from protojson: `fb995f184a/internal/impl/message_reflect_field.go (L327)` `fb995f184a/encoding/protojson/decode_test.go (L134)` `fb995f184a/encoding/protojson/decode_test.go (L156)` We do not support `optional` keyword and the generator will fail if it sees on. So only implement the default behaviour. Refs #122 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>	2024-10-11 14:40:54 +03:00

Evgenii Stratonikov

f0fc40e116

[#123 ] Resolve funlen linter issue

DCO action / DCO (pull_request) Successful in 55s

Details

Tests and linters / Tests with -race (pull_request) Successful in 1m8s

Details

Tests and linters / Tests (pull_request) Successful in 1m31s

Details

Tests and linters / Lint (pull_request) Successful in 1m58s

Details

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

2024-10-11 14:40:54 +03:00

Evgenii Stratonikov

29f2157563

[#123 ] protogen: Treat bytes field as non-nullable

In protobuf 3.12 they have added an support for `optional` keyword,
which has made it into the main branch in 3.15.
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md
https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis

This means that without an explicit `optional` keyword field presence
for scalars is not tracked, thus empty string in JSON should be
unmarshaled to a nil byte slice. Relevant decoding code and tests from
protojson:
fb995f184a/internal/impl/message_reflect_field.go (L327)
fb995f184a/encoding/protojson/decode_test.go (L134)
fb995f184a/encoding/protojson/decode_test.go (L156)

We do not support `optional` keyword and the generator will fail if it sees on.
So only implement the default behaviour.

Refs #122

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

2024-10-11 14:40:54 +03:00

1 changed files with 1 additions and 0 deletions

									
										1

util/proto/marshal_test.go
									
										View file
										
				@ -51,6 +51,7 @@ func TestStableMarshalSingle(t *testing.T) {

							var actualFrostfs generated.Primitives

							require.NoError(t, actualFrostfs.UnmarshalJSON(r))

							require.Equal(t, input, &actualFrostfs)

							primitivesEqual(t, input, &actual)

						})

					})

Compare commits

2 commits

bba4af93d6 ... f0fc40e116

1

util/proto/marshal_test.go

View file

Rows
Columns

Compare commits

2 commits bba4af93d6 ... f0fc40e116

1 util/proto/marshal_test.go Unescape Escape View file

2 commits

bba4af93d6 ... f0fc40e116

1

util/proto/marshal_test.go

View file