TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

feature/frostfs_system_attribute #10

Merged
fyrchik merged 1 commit from dkirillov/frostfs-api-go:feature/frostfs_system_attribute into master 2023-07-26 21:08:03 +00:00
Conversation 0 Commits 1 Files changed 5 +71 -14
dkirillov commented 2023-03-10 06:53:36 +00:00
Member
Copy link
No description provided.
dkirillov self-assigned this 2023-03-10 06:53:36 +00:00
dkirillov force-pushed feature/frostfs_system_attribute from ff94485312 to 3369fd4240 2023-03-10 06:54:23 +00:00 Compare
dkirillov changed title from WIP: feature/frostfs_system_attribute to feature/frostfs_system_attribute 2023-03-10 06:55:35 +00:00
dkirillov requested review from storage-core-committers 2023-03-10 06:55:49 +00:00
dkirillov requested review from storage-core-developers 2023-03-10 06:55:49 +00:00
dkirillov requested review from storage-services-committers 2023-03-10 06:55:49 +00:00
dkirillov requested review from storage-services-developers 2023-03-10 06:55:49 +00:00
fyrchik approved these changes 2023-03-10 07:01:12 +00:00
fyrchik reviewed 2023-03-10 07:02:29 +00:00
container/attributes.go Outdated
@ -18,2 +18,4 @@
)
// SysAttributePrefixFrostFS is a prefix of key to system attribute.
const SysAttributePrefixFrostFS = "__FROSTFS__"
fyrchik commented 2023-03-10 07:02:29 +00:00
Owner
Copy link

I am wondering if it is better to use *NeoFS for legacy stuff and no suffix for a new one.
What do you think?

I am wondering if it is better to use `*NeoFS` for legacy stuff and no suffix for a new one. What do you think?
👍 3
realloc commented 2023-03-10 07:26:43 +00:00
Owner
Copy link

I suggest keep using a prefix to avoid naming collisions and keep logical separations fro attributes affecting system behavior.

I suggest keep using a prefix to avoid naming collisions and keep logical separations fro attributes affecting system behavior.
😆 1
realloc commented 2023-03-10 08:42:39 +00:00
Owner
Copy link

Ah! I get it now. Agree =)

Ah! I get it now. Agree =)
carpawell commented 2023-03-10 14:38:13 +00:00
Contributor
Copy link

@fyrchik, dont we need any system prefix? it may not have any relations to a product name but be more neutral, e.g. __SYSTEM__

@fyrchik, dont we need any system prefix? it may not have any relations to a product name but be more neutral, e.g. `__SYSTEM__`
👍 1
fyrchik commented 2023-03-13 11:48:31 +00:00
Owner
Copy link

I like the __SYSTEM__ idea, but we probably need another round of PRs for that :)

I like the `__SYSTEM__` idea, but we probably need another round of PRs for that :)
👍 1
alexvanin reviewed 2023-03-10 08:40:39 +00:00
netmap/attributes.go Outdated
@ -11,6 +11,9 @@ import (
// prefix of keys to subnet attributes.
const attrSubnetPrefix = "__NEOFS__SUBNET_"
alexvanin commented 2023-03-10 08:40:37 +00:00
Owner
Copy link

What you think about having // Deprecated: use FrostFS 'attrSubnetPrefixFrostFS' to such code or is it too early for this?

@fyrchik @dkirillov @carpawell

What you think about having `// Deprecated: use FrostFS 'attrSubnetPrefixFrostFS'` to such code or is it too early for this? @fyrchik @dkirillov @carpawell
carpawell commented 2023-03-10 14:33:57 +00:00
Contributor
Copy link

I would just remove that but there are also other thoughts on it.

I would just remove that but there are also other thoughts on it.
dkirillov force-pushed feature/frostfs_system_attribute from 3369fd4240 to 31be126b74 2023-03-10 10:43:05 +00:00 Compare
alexvanin approved these changes 2023-03-10 14:28:43 +00:00
dkirillov force-pushed feature/frostfs_system_attribute from 31be126b74 to cd2e46a17c 2023-03-13 06:59:34 +00:00 Compare
acid-ant approved these changes 2023-03-13 07:01:37 +00:00
fyrchik approved these changes 2023-03-13 11:50:46 +00:00
fyrchik merged commit cd2e46a17c into master 2023-03-13 11:51:06 +00:00
fyrchik referenced this pull request from a commit 2023-03-13 11:51:06 +00:00
[#10] Generate api
dkirillov deleted branch feature/frostfs_system_attribute 2023-03-15 09:21:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#10
No description provided.
Delete branch "dkirillov/frostfs-api-go:feature/frostfs_system_attribute"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?