TrueCloudLab/frostfs-api-go

Autogenerate stable marshalers #40

New issue

Open

opened 2023-06-02 14:45:32 +00:00 by fyrchik · 3 comments

fyrchik commented

2023-06-02 14:45:32 +00:00

Owner

It seems we don't use protogen to generate files in this repo, like in node:
https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/Makefile#L79

Let's fix this. I think we missed marshaling part from #35.

It seems we don't use protogen to generate files in this repo, like in node: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/Makefile#L79 Let's fix this. I think we missed marshaling part from #35.

fyrchik commented

2023-06-02 14:48:31 +00:00

Author

Owner

So the file container/marshal.go, for example, will be replaced with container/something_neofs.pb.go and will contain the same code, minus constant definitions.

So the file `container/marshal.go`, for example, will be replaced with `container/something_neofs.pb.go` and will contain the same code, minus constant definitions.

aarifullin was assigned by fyrchik

2023-06-02 14:48:35 +00:00

fyrchik commented

2023-06-02 14:49:57 +00:00

Author

Owner

We might miss oneOf currently https://git.frostfs.info/TrueCloudLab/frostfs-api-go/src/branch/master/object/marshal.go#L462

We _might_ miss oneOf currently https://git.frostfs.info/TrueCloudLab/frostfs-api-go/src/branch/master/object/marshal.go#L462

aarifullin referenced this issue

2023-06-12 22:37:43 +00:00

WIP: [#40] types: Generate StableMarshaler methods for refs #41

aarifullin referenced this issue

2023-06-12 22:44:47 +00:00

WIP: [#40] types: Generate StableMarshaler methods for refs #41

~~aarifullin referenced this issue 2023-06-21 20:26:37 +00:00~~

WIP: Generate StableMarshaler/StableSize methods for protobufs #43

aarifullin referenced this issue

2023-07-10 12:31:44 +00:00

WIP: [#40] types: Generate StableMarshaler/StableSize methods for protobufs #46

aarifullin added the

label 2023-08-31 15:58:10 +00:00

aarifullin commented

2023-08-31 15:58:29 +00:00

Member

Blocked by TrueCloudLab/frostfs-sdk-go#121

Blocked by https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/121

aarifullin added the

label 2023-08-31 15:58:38 +00:00

fyrchik self-assigned this 2024-04-26 10:08:17 +00:00

aarifullin was unassigned by fyrchik

2024-04-26 10:08:23 +00:00

fyrchik referenced this issue

2024-04-26 10:16:36 +00:00

Move to a custom protobuf code generator #78

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#40

No description provided.