TrueCloudLab/frostfs-api-go
21
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

Make setter names more consistent #76

Merged
fyrchik merged 1 commit from fyrchik/frostfs-api-go:fix-setter-names into master 2024-05-03 13:42:19 +00:00
Conversation 1 Commits 1 Files changed 10 +36 -36
fyrchik commented 2024-04-26 10:06:58 +00:00
Owner
Copy link

This will make the transition to a new codegen more seamless.

  1. Setter should be named as the field itself.
  2. Setter should accept 1 parameter.
This will make the transition to a new codegen more seamless. 1. Setter should be named as the field itself. 2. Setter should accept 1 parameter.
fyrchik force-pushed fix-setter-names from caa35d1dc6 to b9790e6f67 2024-04-26 10:07:22 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-04-26 10:18:12 +00:00
fyrchik requested review from storage-core-developers 2024-04-26 10:18:12 +00:00
acid-ant approved these changes 2024-04-26 19:24:28 +00:00
fyrchik added the
internal
 label 2024-04-27 06:55:09 +00:00
fyrchik commented 2024-05-02 11:57:33 +00:00
Author
Owner
Copy link

Only rebase.

Only rebase.
fyrchik force-pushed fix-setter-names from b9790e6f67 to 9ffc947f60 2024-05-02 11:57:33 +00:00 Compare
acid-ant reviewed 2024-05-02 12:14:25 +00:00
object/grpc/service.go Outdated
@ -282,8 +282,8 @@ func (m *HeadResponse_Body) SetSplitInfo(v *SplitInfo) {
}
}
// SetECInfo sets meta info about the erasure coded object.
acid-ant commented 2024-05-02 12:14:25 +00:00
Member
Copy link

Looks like func (m *GetRangeResponse_Body) SetECInfo(v *ECInfo) {..} also needs to refactor.

Looks like `func (m *GetRangeResponse_Body) SetECInfo(v *ECInfo) {..}` also needs to refactor.
fyrchik commented 2024-05-03 05:32:50 +00:00
Author
Owner
Copy link

Fixed.
Strange, I have first rebased #77 on top of this and got no errors.

Fixed. Strange, I have first rebased #77 on top of this and got no errors.
acid-ant reviewed 2024-05-02 12:15:39 +00:00
object/convert.go Outdated
@ -1486,7 +1486,7 @@ func (r *HeadResponseBody) ToGRPCMessage() grpc.Message {
case *SplitInfo:
m.SetSplitInfo(v.ToGRPCMessage().(*object.SplitInfo))
case *ECInfo:
acid-ant commented 2024-05-02 12:15:39 +00:00
Member
Copy link

The same changes required for func (r *GetRangeResponseBody) ToGRPCMessage() grpc.Message {...}?

The same changes required for `func (r *GetRangeResponseBody) ToGRPCMessage() grpc.Message {...}`?
fyrchik commented 2024-05-03 05:33:56 +00:00
Author
Owner
Copy link

Fixed

Fixed
fyrchik force-pushed fix-setter-names from 9ffc947f60 to 0219fb0881 2024-05-03 05:34:16 +00:00 Compare
fyrchik force-pushed fix-setter-names from 0219fb0881 to 0fe6b9adbb 2024-05-03 05:52:14 +00:00 Compare
fyrchik merged commit 0fe6b9adbb into master 2024-05-03 13:42:19 +00:00
fyrchik deleted branch fix-setter-names 2024-05-03 13:42:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#76
No description provided.
Delete branch "fyrchik/frostfs-api-go:fix-setter-names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?