TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

netmap: Regenerate to add LIKE operation for filter #87

Merged
fyrchik merged 5 commits from acid-ant/frostfs-api-go:feature/policy-like into master 2024-09-04 19:51:16 +00:00
Conversation 0 Commits 5 Files changed 6 +49 -32
acid-ant commented 2024-06-24 11:58:14 +00:00
Member
Copy link

Also add in Makefile new target protoc-install

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Also add in Makefile new target `protoc-install` Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/policy-like from 6e34ade89b to bca2b6a414 2024-06-24 11:59:48 +00:00 Compare
aarifullin reviewed 2024-06-24 12:46:18 +00:00
netmap/types.go Outdated
@ -114,2 +114,4 @@
LIKE
)
const LIKE_WILDCARD = "*"
aarifullin commented 2024-06-24 12:46:18 +00:00
Member
Copy link

The linter doesn't pass this snake-case name :(

The linter doesn't pass this snake-case name :(
acid-ant commented 2024-06-24 13:03:20 +00:00
Author
Member
Copy link

Thanks, fixed.

Thanks, fixed.
aarifullin marked this conversation as resolved
acid-ant force-pushed feature/policy-like from bca2b6a414 to eed7162e68 2024-06-24 13:03:00 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-06-24 13:03:36 +00:00
acid-ant requested review from storage-core-developers 2024-06-24 13:03:40 +00:00
dstepanov-yadro reviewed 2024-06-24 14:07:56 +00:00
Makefile Outdated
@ -41,3 +64,3 @@
@for f in `find . -type f -name '*.proto' -not -path './vendor/*'`; do \
echo "⇒ Processing $$f "; \
protoc \
$(PROTOC_DIR)/bin/protoc \
dstepanov-yadro commented 2024-06-24 14:07:21 +00:00
Member
Copy link

protoc target should be also fixed like in frostfs-node

`protoc` target should be also fixed like in `frostfs-node`
acid-ant commented 2024-06-24 15:59:17 +00:00
Author
Member
Copy link

You mean check for PROTOC_DIR and PROTOC_GEN_GO_DIR? Added.

You mean check for `PROTOC_DIR` and `PROTOC_GEN_GO_DIR`? Added.
acid-ant commented 2024-06-25 06:27:57 +00:00
Author
Member
Copy link

Also removed redundant steps from target protoc.

Also removed redundant steps from target `protoc`.
acid-ant force-pushed feature/policy-like from eed7162e68 to c55fbd1e87 2024-06-24 15:59:16 +00:00 Compare
acid-ant force-pushed feature/policy-like from c55fbd1e87 to ffd9d34365 2024-06-25 06:27:18 +00:00 Compare
aarifullin approved these changes 2024-06-25 07:36:57 +00:00
dstepanov-yadro approved these changes 2024-06-25 12:03:02 +00:00
elebedeva approved these changes 2024-06-27 08:49:40 +00:00
acid-ant force-pushed feature/policy-like from ffd9d34365 to 05d0f8e092 2024-07-01 06:34:34 +00:00 Compare
acid-ant force-pushed feature/policy-like from 05d0f8e092 to c01406ce25 2024-08-06 14:24:23 +00:00 Compare
fyrchik reviewed 2024-08-07 07:28:18 +00:00
netmap/types.go Outdated
@ -114,2 +114,4 @@
LIKE
)
const LikeWildcard = "*"
fyrchik commented 2024-08-07 07:28:16 +00:00
Owner
Copy link

I don't think it is useful -- almost always better to inline it in policy, than do ip ~ ".." + LikeWildcard

I don't think it is useful -- almost always better to inline it in policy, than do `ip ~ ".." + LikeWildcard`
acid-ant commented 2024-08-07 13:23:14 +00:00
Author
Member
Copy link

Ok, removed.

Ok, removed.
acid-ant force-pushed feature/policy-like from c01406ce25 to 35e7397d48 2024-08-07 13:22:10 +00:00 Compare
fyrchik approved these changes 2024-08-07 16:04:05 +00:00
fyrchik merged commit 35e7397d48 into master 2024-08-07 16:04:10 +00:00
fyrchik referenced this pull request from a commit 2024-08-07 16:04:12 +00:00
[#87] netmap: Extend enum `Operation`
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
dstepanov-yadro
elebedeva
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#87
No description provided.
Delete branch "acid-ant/frostfs-api-go:feature/policy-like"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?