netmap: Regenerate to add LIKE operation for filter #87

Merged
fyrchik merged 1 commit from acid-ant/frostfs-api-go:feature/policy-like into master 2024-09-04 19:51:16 +00:00
Member

Also add in Makefile new target protoc-install

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Also add in Makefile new target `protoc-install` Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/policy-like from 6e34ade89b to bca2b6a414 2024-06-24 11:59:48 +00:00 Compare
aarifullin reviewed 2024-06-24 12:46:18 +00:00
netmap/types.go Outdated
@ -114,2 +114,4 @@
LIKE
)
const LIKE_WILDCARD = "*"
Member

The linter doesn't pass this snake-case name :(

The linter doesn't pass this snake-case name :(
Author
Member

Thanks, fixed.

Thanks, fixed.
aarifullin marked this conversation as resolved
acid-ant force-pushed feature/policy-like from bca2b6a414 to eed7162e68 2024-06-24 13:03:00 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-06-24 13:03:36 +00:00
acid-ant requested review from storage-core-developers 2024-06-24 13:03:40 +00:00
dstepanov-yadro reviewed 2024-06-24 14:07:56 +00:00
Makefile Outdated
@ -41,3 +64,3 @@
@for f in `find . -type f -name '*.proto' -not -path './vendor/*'`; do \
echo "⇒ Processing $$f "; \
protoc \
$(PROTOC_DIR)/bin/protoc \

protoc target should be also fixed like in frostfs-node

`protoc` target should be also fixed like in `frostfs-node`
Author
Member

You mean check for PROTOC_DIR and PROTOC_GEN_GO_DIR? Added.

You mean check for `PROTOC_DIR` and `PROTOC_GEN_GO_DIR`? Added.
Author
Member

Also removed redundant steps from target protoc.

Also removed redundant steps from target `protoc`.
acid-ant force-pushed feature/policy-like from eed7162e68 to c55fbd1e87 2024-06-24 15:59:16 +00:00 Compare
acid-ant force-pushed feature/policy-like from c55fbd1e87 to ffd9d34365 2024-06-25 06:27:18 +00:00 Compare
aarifullin approved these changes 2024-06-25 07:36:57 +00:00
dstepanov-yadro approved these changes 2024-06-25 12:03:02 +00:00
elebedeva approved these changes 2024-06-27 08:49:40 +00:00
acid-ant force-pushed feature/policy-like from ffd9d34365 to 05d0f8e092 2024-07-01 06:34:34 +00:00 Compare
acid-ant force-pushed feature/policy-like from 05d0f8e092 to c01406ce25 2024-08-06 14:24:23 +00:00 Compare
fyrchik reviewed 2024-08-07 07:28:18 +00:00
netmap/types.go Outdated
@ -114,2 +114,4 @@
LIKE
)
const LikeWildcard = "*"
Owner

I don't think it is useful -- almost always better to inline it in policy, than do ip ~ ".." + LikeWildcard

I don't think it is useful -- almost always better to inline it in policy, than do `ip ~ ".." + LikeWildcard`
Author
Member

Ok, removed.

Ok, removed.
acid-ant force-pushed feature/policy-like from c01406ce25 to 35e7397d48 2024-08-07 13:22:10 +00:00 Compare
fyrchik approved these changes 2024-08-07 16:04:05 +00:00
fyrchik merged commit 35e7397d48 into master 2024-08-07 16:04:10 +00:00
fyrchik referenced this pull request from a commit 2024-08-07 16:04:12 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#87
No description provided.