Rewrite stable marshaling tests #89

New issue

Closed

opened 2024-07-15 12:52:39 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-07-15 12:52:39 +00:00

Owner

I am frustrated with how our tests on stable marshaling are written.

We test the routines that directly use protowire, but we do not test end-to-end scenario.
Adding new testcases is a pain. I have recently tried to support packed attributes.

The suggestion is to use protogen to generate testdata then compare compatibility with the vanilla protobuf.
We may fix this after #77.

I am frustrated with how our tests on stable marshaling are written. 1. We test the routines that directly use `protowire`, but we do not test end-to-end scenario. 2. Adding new testcases is a pain. I have recently tried to support `packed` attributes. The suggestion is to _use_ protogen to generate testdata then compare compatibility with the vanilla protobuf. We may fix this after #77.