TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Refactor Patch related structs and fix for serviceMessageBody #97

Merged
fyrchik merged 2 commits from aarifullin/frostfs-api-go:fix/patch/1 into master 2024-09-04 19:51:17 +00:00
Conversation 0 Commits 2 Files changed 5 +115 -39
aarifullin commented 2024-07-30 14:52:34 +00:00
Member
Copy link
  • Add getters and setters for related types;
  • Fix unit-tests;
  • Fix serviceMessageBody.
* Add getters and setters for related types; * Fix unit-tests; * Fix `serviceMessageBody`.
aarifullin added 2 commits 2024-07-30 14:52:38 +00:00 
* Add getters and setters for related types;
* Fix unit-tests.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
[#XX] signature: Add Patch messages to serviceMessageBody
Some checks failed
Tests and linters / Tests (1.19) (pull_request) Successful in 44s
Details
DCO action / DCO (pull_request) Failing after 53s
Details
Tests and linters / Lint (pull_request) Successful in 56s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m8s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m43s
Details
5d7f41b104 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed fix/patch/1 from 5d7f41b104 to c27b978770 2024-07-30 14:53:06 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-07-30 14:53:10 +00:00
aarifullin requested review from storage-core-developers 2024-07-30 14:53:10 +00:00
dstepanov-yadro approved these changes 2024-07-30 14:55:57 +00:00
fyrchik approved these changes 2024-07-30 16:29:09 +00:00
fyrchik merged commit c27b978770 into master 2024-07-30 16:29:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#97
No description provided.
Delete branch "aarifullin/frostfs-api-go:fix/patch/1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?