.gitlint

@@ -1,10 +0,0 @@
-[general]
-fail-without-commits=true
-contrib=CC1
-
-[title-match-regex]
-regex=^\[\#[0-9Xx]+\]\s
-
-[ignore-by-title]
-regex=^Release(.*)
-ignore=title-match-regex

.pre-commit-config.yaml

@@ -18,13 +18,25 @@ repos:
     - id: end-of-file-fixer
       exclude: ".key$"
 
+  - repo: local
+    hooks:
+       - id: gofumpt
+         name: gofumpt
+         entry: make fumpt
+         pass_filenames: false
+         types: [go]
+         language: system
+
+  - repo: local
+    hooks:
+       - id: go-unit-tests
+         name: go unit tests
+         entry: make test GOFLAGS=''
+         pass_filenames: false
+         types: [go]
+         language: system
+
   - repo: https://github.com/golangci/golangci-lint
-    rev: v1.51.2
+    rev: v1.56.2
     hooks:
     - id: golangci-lint
-
-  - repo: https://github.com/jorisroovers/gitlint
-    rev:  v0.18.0
-    hooks:
-      - id: gitlint
-        stages: [commit-msg]

Makefile

@@ -3,40 +3,35 @@ SHELL = bash
 
 VERSION ?= $(shell git describe --tags --match "v*" --abbrev=8 --dirty --always)
 
-.PHONY: dep fmts fmt imports protoc test lint version help
+.PHONY: dep fmts fumpt imports protoc test lint version help
 
 # Pull go dependencies
 dep:
 	@printf "⇒ Tidy requirements : "
 	CGO_ENABLED=0 \
-	GO111MODULE=on \
 	go mod tidy -v && echo OK
 	@printf "⇒ Download requirements: "
 	CGO_ENABLED=0 \
-	GO111MODULE=on \
 	go mod download && echo OK
 	@printf "⇒ Install test requirements: "
 	CGO_ENABLED=0 \
-	GO111MODULE=on \
 	go test ./... && echo OK
 
 # Run all code formatters
-fmts: fmt imports
+fmts: fumpt imports
-
-# Reformat code
-fmt:
-	@echo "⇒ Processing gofmt check"
-	@for f in `find . -type f -name '*.go' -not -path './vendor/*' -not -name '*.pb.go' -prune`; do \
-		GO111MODULE=on gofmt -s -w $$f; \
-	done
 
 # Reformat imports
 imports:
 	@echo "⇒ Processing goimports check"
 	@for f in `find . -type f -name '*.go' -not -path './vendor/*' -not -name '*.pb.go' -prune`; do \
-		GO111MODULE=on goimports -w $$f; \
+		goimports -w $$f; \
 	done
 
+# Run gofumpt
+fumpt:
+	@echo "⇒ Processing gofumpt check"
+	@gofumpt -l -w .
+
 # Regenerate code for proto files
 protoc:
 	@GOPRIVATE=github.com/TrueCloudLab go mod vendor
@@ -54,9 +49,10 @@ protoc:
 	rm -rf vendor
 
 # Run Unit Test with go test
+test: GOFLAGS ?= "-count=1"
 test:
 	@echo "⇒ Running go test"
-	@GO111MODULE=on go test ./... -count=1
+	@GOFLAGS="$(GOFLAGS)" go test ./...
 
 # Run linters
 lint:

object/attributes_test.go

@@ -10,7 +10,7 @@ import (
 func TestSetNotification(t *testing.T) {
 	o := new(Object)
 
-	var ni = NotificationInfo{
+	ni := NotificationInfo{
 		epoch: 10,
 		topic: "test",
 	}

object/types.go

@@ -318,8 +318,7 @@ type PutSingleRequest struct {
 	session.RequestHeaders
 }
 
-type PutSingleResponseBody struct {
+type PutSingleResponseBody struct{}
-}
 
 type PutSingleResponse struct {
 	body *PutSingleResponseBody

session/types.go

@@ -632,7 +632,8 @@ func (r *ResponseMetaHeader) SetStatus(v *status.Status) {
 func SetStatus(msg interface {
 	GetMetaHeader() *ResponseMetaHeader
 	SetMetaHeader(*ResponseMetaHeader)
-}, st *status.Status) {
+}, st *status.Status,
+) {
 	meta := msg.GetMetaHeader()
 	if meta == nil {
 		meta = new(ResponseMetaHeader)

session/util.go

@@ -43,7 +43,8 @@ func (c *RequestHeaders) SetVerificationHeader(v *RequestVerificationHeader) {
 func (c *RequestHeaders) ToMessage(m interface {
 	SetMetaHeader(*session.RequestMetaHeader)
 	SetVerifyHeader(*session.RequestVerificationHeader)
-}) {
+},
+) {
 	m.SetMetaHeader(c.metaHeader.ToGRPCMessage().(*session.RequestMetaHeader))
 	m.SetVerifyHeader(c.verifyHeader.ToGRPCMessage().(*session.RequestVerificationHeader))
 }
@@ -51,7 +52,8 @@ func (c *RequestHeaders) ToMessage(m interface {
 func (c *RequestHeaders) FromMessage(m interface {
 	GetMetaHeader() *session.RequestMetaHeader
 	GetVerifyHeader() *session.RequestVerificationHeader
-}) error {
+},
+) error {
 	metaHdr := m.GetMetaHeader()
 	if metaHdr == nil {
 		c.metaHeader = nil
@@ -122,7 +124,8 @@ func (c *ResponseHeaders) SetVerificationHeader(v *ResponseVerificationHeader) {
 func (c *ResponseHeaders) ToMessage(m interface {
 	SetMetaHeader(*session.ResponseMetaHeader)
 	SetVerifyHeader(*session.ResponseVerificationHeader)
-}) {
+},
+) {
 	m.SetMetaHeader(c.metaHeader.ToGRPCMessage().(*session.ResponseMetaHeader))
 	m.SetVerifyHeader(c.verifyHeader.ToGRPCMessage().(*session.ResponseVerificationHeader))
 }
@@ -130,7 +133,8 @@ func (c *ResponseHeaders) ToMessage(m interface {
 func (c *ResponseHeaders) FromMessage(m interface {
 	GetMetaHeader() *session.ResponseMetaHeader
 	GetVerifyHeader() *session.ResponseVerificationHeader
-}) error {
+},
+) error {
 	metaHdr := m.GetMetaHeader()
 	if metaHdr == nil {
 		c.metaHeader = nil

util/proto/marshal_test.go

@@ -50,9 +50,7 @@ func (s *stablePrimitives) stableMarshal(buf []byte, wrongField bool) ([]byte, e
 		buf = make([]byte, s.stableSize())
 	}
 
-	var (
+	var i, offset, fieldNum int
-		i, offset, fieldNum int
-	)
 
 	fieldNum = 1
 	if wrongField {

util/signature/walletconnect/sign_test.go

@@ -109,5 +109,4 @@ func TestVerifyNeonWallet(t *testing.T) {
 		}
 		require.True(t, VerifyMessage(nil, sm))
 	}
-
 }