TrueCloudLab/frostfs-api
26
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

object: Extend Delete rpc specification #29

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api:feature/197-extend_delete_spec into master 2023-06-30 07:57:25 +00:00
Conversation 1 Commits 1 Files changed 1 +3
aarifullin commented 2023-06-15 08:41:28 +00:00
Member
Copy link
  • Add OBJECT_NOT_FOUND status specification

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Add OBJECT_NOT_FOUND status specification Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
 label 2023-06-15 08:41:28 +00:00
aarifullin requested review from alexvanin 2023-06-15 08:41:37 +00:00
aarifullin requested review from storage-core-committers 2023-06-15 08:41:37 +00:00
aarifullin requested review from storage-core-developers 2023-06-15 08:41:38 +00:00
aarifullin changed title from [#XX] object: Extend Delete rpc specification to [#29] object: Extend Delete rpc specification 2023-06-15 08:41:45 +00:00
realloc changed title from [#29] object: Extend Delete rpc specification to object: Extend Delete rpc specification 2023-06-16 11:10:30 +00:00
realloc reviewed 2023-06-16 11:11:51 +00:00
object/service.proto Outdated
@ -109,1 +109,3 @@
// provided session token has expired.
// provided session token has expired;
// - **OBJECT_ALREADY_REMOVED** (2052, SECTION_OBJECT): \
// the requested object has been already marked to delete;
realloc commented 2023-06-16 11:11:51 +00:00
Owner
Copy link

The requested object has already been marked for deletion.

The requested object has already been marked for deletion.
dstepanov-yadro approved these changes 2023-06-19 11:45:40 +00:00
aarifullin changed title from object: Extend Delete rpc specification to WIP: object: Extend Delete rpc specification 2023-06-20 09:10:52 +00:00
fyrchik reviewed 2023-06-21 06:37:25 +00:00
object/service.proto Outdated
@ -108,2 +108,3 @@
// - **TOKEN_EXPIRED** (4097, SECTION_SESSION): \
// provided session token has expired.
// provided session token has expired;
// - **OBJECT_ALREADY_REMOVED** (2052, SECTION_OBJECT): \
fyrchik commented 2023-06-21 06:37:25 +00:00
Owner
Copy link

What about sorting the codes by number?

What about sorting the codes by number?
aarifullin commented 2023-06-27 09:05:03 +00:00
Author
Member
Copy link
  1. Commentaries have been corted by code numbers
  2. OBJECT_ALREADY_REMOVED has been removed out because we decided to not return this error for Delete
1. Commentaries have been corted by code numbers 2. `OBJECT_ALREADY_REMOVED` has been removed out because we decided to not return this error for `Delete`
aarifullin force-pushed feature/197-extend_delete_spec from 5c891f39e4 to 427104279d 2023-06-27 09:03:15 +00:00 Compare
aarifullin changed title from WIP: object: Extend Delete rpc specification to object: Extend Delete rpc specification 2023-06-27 09:03:32 +00:00
aarifullin requested review from storage-core-committers 2023-06-27 09:05:22 +00:00
aarifullin requested review from storage-core-developers 2023-06-27 09:05:23 +00:00
acid-ant commented 2023-06-27 09:40:49 +00:00
Member
Copy link

Please update commit message.

Please update commit message.
acid-ant approved these changes 2023-06-27 09:41:09 +00:00
dstepanov-yadro approved these changes 2023-06-28 06:27:12 +00:00
aarifullin force-pushed feature/197-extend_delete_spec from 427104279d to b471eaaba9 2023-06-28 10:31:16 +00:00 Compare
aarifullin requested review from acid-ant 2023-06-28 10:31:32 +00:00
aarifullin requested review from dstepanov-yadro 2023-06-28 10:31:33 +00:00
dstepanov-yadro approved these changes 2023-06-28 11:24:25 +00:00
fyrchik approved these changes 2023-06-30 07:57:07 +00:00
fyrchik merged commit b471eaaba9 into master 2023-06-30 07:57:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
acid-ant
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#29
No description provided.
Delete branch "aarifullin/frostfs-api:feature/197-extend_delete_spec"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?