TrueCloudLab/frostfs-api
26
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

status: Introduce CONTAINER_ACCESS_DENIED status #40

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api:feat/cnt_access_denied_status into master 2024-03-20 09:48:36 +00:00
Conversation 0 Commits 1 Files changed 12 +411 -194
aarifullin commented 2024-03-05 09:41:57 +00:00
Member
Copy link

The introduced CONTAINER_ACCESS_DENIED can be used by APE middleware check in container service.

The introduced `CONTAINER_ACCESS_DENIED` can be used by APE middleware check in container service.
aarifullin force-pushed feat/cnt_access_denied_status from 8739dd1070 to f574a7a85a 2024-03-05 09:42:20 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-03-05 09:42:35 +00:00
aarifullin requested review from storage-core-developers 2024-03-05 09:42:35 +00:00
fyrchik reviewed 2024-03-05 09:47:43 +00:00
status/types.proto Outdated
@ -135,1 +135,4 @@
EACL_NOT_FOUND = 1;
// [**3074**] Container access denied.
CONTAINER_ACCESS_DENIED = 2;
fyrchik commented 2024-03-05 09:47:43 +00:00
Owner
Copy link

It also needs to be mentions in all RPCs, where it could be returned.
See object/service.proto for an example.

It also needs to be mentions in all RPCs, where it could be returned. See [object/service.proto](https://git.frostfs.info/TrueCloudLab/frostfs-api/src/commit/188f580e469c9fafc603a1ff3c54933e7cf8b820/object/service.proto#L36) for an example.
👍 1
aarifullin commented 2024-03-05 11:16:13 +00:00
Author
Member
Copy link

Fixed. Also, I have regenerated mds but it seems I use another version of protoc-gen-doc plugin and the docs are reformatted. Is it critical?

Fixed. Also, I have regenerated `md`s but it seems I use another version of `protoc-gen-doc` plugin and the docs are reformatted. Is it critical?
aarifullin force-pushed feat/cnt_access_denied_status from f574a7a85a to e1e2713eb7 2024-03-05 11:12:50 +00:00 Compare
acid-ant reviewed 2024-03-05 12:24:09 +00:00
container/service.proto Outdated
@ -26,1 +26,3 @@
// - Common failures (SECTION_FAILURE_COMMON).
// - Common failures (SECTION_FAILURE_COMMON);
// - **CONTAINER_ACCESS_DENIED** (3074, SECTION_CONTAINER): \
// container write access denied.
acid-ant commented 2024-03-05 12:23:31 +00:00
Member
Copy link

Maybe container cerate access denied.?

Maybe `container cerate access denied.`?
aarifullin commented 2024-03-05 12:55:25 +00:00
Author
Member
Copy link

Good point. Fixed

Good point. Fixed
aarifullin force-pushed feat/cnt_access_denied_status from e1e2713eb7 to 18de104072 2024-03-05 12:56:30 +00:00 Compare
dstepanov-yadro approved these changes 2024-03-05 14:33:00 +00:00
acid-ant approved these changes 2024-03-05 14:37:07 +00:00
aarifullin force-pushed feat/cnt_access_denied_status from 18de104072 to 07eb6a438c 2024-03-20 09:25:12 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2024-03-20 09:26:28 +00:00
aarifullin requested review from acid-ant 2024-03-20 09:26:31 +00:00
fyrchik approved these changes 2024-03-20 09:48:08 +00:00
fyrchik merged commit 07eb6a438c into master 2024-03-20 09:48:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#40
No description provided.
Delete branch "aarifullin/frostfs-api:feat/cnt_access_denied_status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?