TrueCloudLab/frostfs-api
27
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

object: Introduce parent_split_id and parent_index for EC #48

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api:feat/ec_header into master 2024-05-13 09:35:16 +00:00
Conversation 0 Commits 1 Files changed 2 +8
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
object/types.proto
View file

@ -208,6 +208,12 @@ message Header {
uint32 header_length = 4 [ json_name = "headerLength" ];
// Chunk of a parent header.
bytes header = 5 [ json_name = "header" ];
// As the origin object is EC-splitted its identifier is known to all
// chunks as parent. But parent itself can be a part of Split (does not relate to EC-split).
// In this case parent_split_id should be set.
bytes parent_split_id = 6 [ json_name = "parentSplitID" ];
// Parent's index in Split.
uint32 parent_split_index = 7 [ json_name = "parentSplitIndex" ];
fyrchik marked this conversation as resolved Outdated
fyrchik commented 2024-05-08 10:28:10 +00:00
Outdated
Review
Copy link

I would use parentSplitIndex to be sure we not misuse it acidentally.

I would use `parentSplitIndex` to be sure we not misuse it acidentally.
aarifullin commented 2024-05-08 12:03:03 +00:00
Outdated
Review
Copy link

Renamed

Renamed
aarifullin marked this conversation as resolved Outdated
fyrchik commented 2024-05-08 12:02:31 +00:00
Outdated
Review
Copy link

JSON name should be changed too.

JSON name should be changed too.
👍 1
aarifullin commented 2024-05-08 12:03:15 +00:00
Outdated
Review
Copy link

Done

Done
}
// Erasure code chunk information.
EC ec = 12 [ json_name = "ec" ];

2
proto-docs/object.md
View file

@ -1064,6 +1064,8 @@ All objects belonging to a single EC group have the same `parent` field.
| total | [uint32](#uint32) | | Total number of chunks in this split. |
| header_length | [uint32](#uint32) | | Total length of a parent header. Used to trim padding zeroes. |
| header | [bytes](#bytes) | | Chunk of a parent header. |
| parent_split_id | [bytes](#bytes) | | As the origin object is EC-splitted its identifier is known to all chunks as parent. But parent itself can be a part of Split (does not relate to EC-split). In this case parent_split_id should be set. |
| parent_split_index | [uint32](#uint32) | | Parent's index in Split. |
<a name="neo.fs.v2.object.Header.Split"></a>