TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 18 Pull requests Projects Releases 3 Activity Actions

common: Disallow downgrading contracts #103

Merged
fyrchik merged 1 commit from fyrchik/frostfs-contract:disallow-downgrade into master 2024-08-19 12:28:46 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
fyrchik commented 2024-08-19 08:53:17 +00:00
Owner
Copy link

PrevVersion marks suitable version that we can upgrade from.
However, we can have multiple minor versions, so, currently an upgrade
from v0.19.3 to v0.19.1 is possible. Prevent this with an additional
check.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

`PrevVersion` marks suitable version that we can upgrade from. However, we can have multiple minor versions, so, currently an upgrade from v0.19.3 to v0.19.1 is possible. Prevent this with an additional check. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-08-19 08:53:21 +00:00
common: Disallow downgrading contracts
Some checks failed
DCO action / DCO (pull_request) Failing after 1m16s
Details
Tests / Tests (1.21) (pull_request) Successful in 1m36s
Details
Tests / Tests (1.22) (pull_request) Successful in 2m0s
Details
0e9e5b829d 
`PrevVersion` marks suitable version that we can upgrade from.
However, we can have multiple minor versions, so, currently an upgrade
from v0.19.3 to v0.19.1 is possible. Prevent this with an additional
check.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added the
bug
internal
 labels 2024-08-19 08:53:44 +00:00
fyrchik requested review from storage-core-committers 2024-08-19 08:53:55 +00:00
fyrchik requested review from storage-core-developers 2024-08-19 08:53:56 +00:00
fyrchik added this to the v0.20.0 milestone 2024-08-19 08:54:33 +00:00
fyrchik force-pushed disallow-downgrade from 0e9e5b829d to ba7329c3a7 2024-08-19 10:57:11 +00:00 Compare
elebedeva approved these changes 2024-08-19 11:58:20 +00:00
dkirillov approved these changes 2024-08-19 12:26:31 +00:00
fyrchik merged commit ba7329c3a7 into master 2024-08-19 12:28:46 +00:00
fyrchik deleted branch disallow-downgrade 2024-08-19 12:28:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
elebedeva
dkirillov
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.20.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#103
No description provided.
Delete branch "fyrchik/frostfs-contract:disallow-downgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?