[#120] Add waiter to frostfsid client #121

vdomnich-yadro · 2024-10-21T12:48:18Z

vdomnich-yadro commented

2024-10-21 12:48:18 +00:00

Waiter provides a configurable behavior for awaiting transaction completion:

Whether "already exists" error should be ignored or not.
Whether transaction execution result should be examined to ensure that transaction entered block successfully (with the HALT status).

Waiter provides a configurable behavior for awaiting transaction completion: - Whether "already exists" error should be ignored or not. - Whether transaction execution result should be examined to ensure that transaction entered block successfully (with the HALT status).

vdomnich-yadro added 1 commit 2024-10-21 12:48:18 +00:00

[#120 ] Add waiter to frostfsid client

DCO action / DCO (pull_request) Successful in 40s

Details

Code generation / Generate wrappers (pull_request) Successful in 1m21s

Details

Tests / Tests (pull_request) Successful in 1m28s

Details

f7794b06f6

Signed-off-by: Vladimir Domnich <v.domnich@yadro.com>

vdomnich-yadro requested review from fyrchik 2024-10-21 12:48:42 +00:00

vdomnich-yadro requested review from alexvanin 2024-10-21 12:48:42 +00:00

vdomnich-yadro requested review from dkirillov 2024-10-21 12:48:42 +00:00

dkirillov reviewed 2024-10-22 08:12:55 +00:00

commonclient/waiter.go Outdated

					
				@ -0,0 +66,4 @@

					// Waiting failed

					if err != nil {

						return result, err

dkirillov commented

2024-10-22 08:12:55 +00:00

I would write

if err != nil {
		return nil, err
}

or

if !w.options.VerifyExecResults || err != nil {
		return result, err
}

I would write ```golang if err != nil { return nil, err } ``` or ```golang if !w.options.VerifyExecResults || err != nil { return result, err } ```

vdomnich-yadro commented

2024-10-22 08:49:38 +00:00

Fixed via the 2nd suggestion. Thanks!

dkirillov marked this conversation as resolved

dkirillov reviewed 2024-10-22 08:15:41 +00:00

frostfsid/client/client.go Outdated

					
				@ -151,17 +153,21 @@ func New(ra actor.RPCActor, acc *wallet.Account, contract util.Uint160, opt Opti

					if err != nil {

						return nil, fmt.Errorf("init actor: %w", err)

					}

					waiter := commonclient.NewWaiter(act, opt.Waiter)

dkirillov commented

2024-10-22 08:15:41 +00:00

Can we choose other variable name to avoid collision with imported package name?

vdomnich-yadro commented

2024-10-22 08:49:21 +00:00

Fixed, thanks!

dkirillov marked this conversation as resolved

vdomnich-yadro requested review from storage-services-developers 2024-10-22 08:45:57 +00:00

vdomnich-yadro force-pushed vd/8357-add-tx-waiter from f7794b06f6 to 126d98d655

2024-10-22 08:49:11 +00:00

Compare

dkirillov reviewed 2024-10-22 09:17:35 +00:00

frostfsid/client/client.go Outdated

					
				@ -161,2 +165,3 @@

				// NewSimple creates a new Client using exising actor.Actor.

				// NewSimple creates a new Client using existing actor.Actor and default waiter options.

				func NewSimple(act *actor.Actor, contract util.Uint160) *Client {

					waiter := commonclient.NewWaiter(act, commonclient.WaiterOptions{})