Cover frostfsid.GetSubjectExtended() with tests #130

Open
opened 2024-11-20 10:29:37 +00:00 by fyrchik · 0 comments
Owner

We would like it to mirror GetSubject.
I think it should be a single test and checkSubject does both GetSubject and GetSubjectExtended.
I also believe this line is unreachable and should either be removed or have a test covering it.

We would like it to mirror `GetSubject`. I think it should be a single test and `checkSubject` does both `GetSubject` and `GetSubjectExtended`. I also believe [this line](https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/a2c2791146d65887c14fb38a531c01a318fe84cc/frostfsid/frostfsid_contract.go#L445) is unreachable and should either be removed or have a test covering it.
fyrchik added the
good first issue
internal
labels 2024-11-20 10:29:54 +00:00
fyrchik changed title from Cover frostfsid.GetSubjectExtended with tests to Cover frostfsid.GetSubjectExtended() with tests 2024-11-20 10:30:00 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#130
No description provided.