TrueCloudLab/frostfs-contract
23
0
Fork 19
Code Issues 14 Pull requests Projects Releases 2 Activity Actions

container: Use Hash256 for container ID in Delete() #134

Merged
fyrchik merged 2 commits from fyrchik/frostfs-contract:fix-events into master 2024-12-05 08:42:13 +00:00
Conversation 0 Commits 2 Files changed 6 +37 -11
fyrchik commented 2024-12-05 08:25:37 +00:00
Owner
Copy link

This is what we use inside Put(). It leads to a better auto-generated
code.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

This is what we use inside Put(). It leads to a better auto-generated code. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-12-05 08:25:37 +00:00
container: Use Hash256 for container ID in Delete()
Some checks failed
DCO action / DCO (pull_request) Failing after 57s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m52s
Details
Tests / Tests (pull_request) Successful in 1m58s
Details
9977ce9aa6 
This is what we use inside Put(). It leads to a better auto-generated
code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-developers 2024-12-05 08:25:38 +00:00
fyrchik requested review from storage-core-committers 2024-12-05 08:25:38 +00:00
fyrchik force-pushed fix-events from 9977ce9aa6 to fd60119f74 2024-12-05 08:31:15 +00:00 Compare
dstepanov-yadro approved these changes 2024-12-05 08:34:24 +00:00
Dismissed
acid-ant approved these changes 2024-12-05 08:35:10 +00:00
Dismissed
fyrchik force-pushed fix-events from fd60119f74 to 762d7f9f9f 2024-12-05 08:39:12 +00:00 Compare
fyrchik dismissed dstepanov-yadro's review 2024-12-05 08:39:12 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik dismissed acid-ant's review 2024-12-05 08:39:12 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov approved these changes 2024-12-05 08:41:47 +00:00
fyrchik merged commit 762d7f9f9f into master 2024-12-05 08:42:13 +00:00
fyrchik deleted branch fix-events 2024-12-05 08:42:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#134
No description provided.
Delete branch "fyrchik/frostfs-contract:fix-events"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?