TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 18 Pull requests Projects Releases 3 Activity Actions

container: Add SetAdmin #137

Merged
fyrchik merged 2 commits from achuprov/frostfs-contract:feat/add_setAdmin into master 2024-12-12 10:32:45 +00:00
Conversation 0 Commits 2 Files changed 4 +55 -3
achuprov commented 2024-12-10 14:26:22 +00:00
Member
Copy link

Close #136
SetAdmin will allow to manage the root domain of the container.

Close #136 `SetAdmin` will allow to manage the root domain of the `container`.
achuprov added 2 commits 2024-12-10 14:26:22 +00:00 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
[#136] container: Add SetAdmin
All checks were successful
DCO action / DCO (pull_request) Successful in 56s
Details
Code generation / Generate wrappers (pull_request) Successful in 2m6s
Details
Tests / Tests (pull_request) Successful in 2m14s
Details
2824febc8f 
SetAdmin will allow to manage the root domain of the container.

Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from fyrchik 2024-12-10 14:26:22 +00:00
achuprov requested review from storage-core-developers 2024-12-10 14:26:22 +00:00
achuprov requested review from storage-core-committers 2024-12-10 14:26:22 +00:00
achuprov requested review from alexvanin 2024-12-10 14:27:57 +00:00
fyrchik reviewed 2024-12-11 06:08:09 +00:00
common/witness.go Outdated
@ -39,1 +43,4 @@
}
// CheckCommittee panics if the script container is not signed by the committee.
func CheckCommittee() {
fyrchik commented 2024-12-11 06:06:06 +00:00
Owner
Copy link

There is common.CommitteeAddress, this function it not needed.

There is `common.CommitteeAddress`, this function it not needed.
fyrchik commented 2024-12-11 06:08:03 +00:00
Owner
Copy link

I see it was moved -- the NNS one should be removed completely, this PR should not touch anything.

I see it was moved -- the NNS one should be removed completely, this PR should not touch anything.
achuprov force-pushed feat/add_setAdmin from 2824febc8f to 077df6c5d6 2024-12-11 09:23:45 +00:00 Compare
fyrchik reviewed 2024-12-11 09:30:09 +00:00
container/container_contract.go Outdated
@ -568,0 +569,4 @@
func SetAdmin(admin interop.Hash160) {
ctx := storage.GetReadOnlyContext()
if !common.HasUpdateAccess() {
fyrchik commented 2024-12-11 09:30:09 +00:00
Owner
Copy link

It looks strange in SetAdmin. Could you inline it?
See Verify() in proxy contract as an example.

It looks strange in `SetAdmin`. Could you inline it? See `Verify()` in proxy contract as an example.
fyrchik approved these changes 2024-12-11 09:30:50 +00:00
Dismissed
achuprov force-pushed feat/add_setAdmin from 077df6c5d6 to 7e8af9c59f 2024-12-11 10:39:25 +00:00 Compare
achuprov dismissed fyrchik's review 2024-12-11 10:39:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik reviewed 2024-12-12 06:20:33 +00:00
tests/container_test.go Outdated
@ -29,2 +29,4 @@
)
const (
containerRootDomain = "container"
fyrchik commented 2024-12-12 06:20:33 +00:00
Owner
Copy link

This change is completely unrelated to the commit.
Please, revert or move to a separate commit.

This change is completely unrelated to the commit. Please, revert or move to a separate commit.
fyrchik changed title from container: Add SetAdmin to WIP: container: Add SetAdmin 2024-12-12 06:27:54 +00:00
achuprov force-pushed feat/add_setAdmin from 7e8af9c59f to 01dc0b077b 2024-12-12 10:19:10 +00:00 Compare
achuprov force-pushed feat/add_setAdmin from 01dc0b077b to 3c7a9cb743 2024-12-12 10:19:47 +00:00 Compare
achuprov changed title from WIP: container: Add SetAdmin to container: Add SetAdmin 2024-12-12 10:30:26 +00:00
achuprov requested review from fyrchik 2024-12-12 10:30:26 +00:00
achuprov requested review from storage-core-committers 2024-12-12 10:30:26 +00:00
fyrchik merged commit 3c7a9cb743 into master 2024-12-12 10:32:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#137
No description provided.
Delete branch "achuprov/frostfs-contract:feat/add_setAdmin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?