Clean up remaining NeoFS mentions #143

New issue

Open

opened 2024-12-13 15:03:09 +00:00 by potyarkin · 1 comment

potyarkin commented

2024-12-13 15:03:09 +00:00

Member

NeoFS is still mentioned in multiple places. Many of those are comments and are easy to fix, but there is also roles.NeoFSAlphabet and I don't feel confident replacing it myself:

Someone more familiar with the codebase should look at this.

$ git ls-files | grep -v CHANGELOG | grep -vP '^\./neo' | grep -vF go.sum | grep -vw copyright | grep -vF '.proto' | xargs grep -i neofs
README.md:`config.json` with corresponding directories to `/var/lib/neofs/contract` for 
common/ir.go:   return roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1))
frostfs/frostfs_contract.go:    alphabetKeys := roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1))
processing/processing_contract.go:      alphabetKeys := roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1))
tests/alphabet_test.go: // set committee as NeoFSAlphabet
tests/alphabet_test.go: designInvoker.Invoke(t, stackitem.Null{}, "designateAsRole", int64(noderoles.NeoFSAlphabet), []any{new})

NeoFS is still mentioned in multiple places. Many of those are comments and are easy to fix, but there is also `roles.NeoFSAlphabet` and I don't feel confident replacing it myself: Someone more familiar with the codebase should look at this. ```console $ git ls-files | grep -v CHANGELOG | grep -vP '^\./neo' | grep -vF go.sum | grep -vw copyright | grep -vF '.proto' | xargs grep -i neofs README.md:`config.json` with corresponding directories to `/var/lib/neofs/contract` for common/ir.go: return roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1)) frostfs/frostfs_contract.go: alphabetKeys := roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1)) processing/processing_contract.go: alphabetKeys := roles.GetDesignatedByRole(roles.NeoFSAlphabet, uint32(blockHeight+1)) tests/alphabet_test.go: // set committee as NeoFSAlphabet tests/alphabet_test.go: designInvoker.Invoke(t, stackitem.Null{}, "designateAsRole", int64(noderoles.NeoFSAlphabet), []any{new}) ```