TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 18 Pull requests Projects Releases 3 Activity Actions

Bump contracts version #15

Merged
fyrchik merged 1 commit from acid-ant/frostfs-contract:bugfix/14-bump-contract-version into master 2023-03-14 09:03:11 +00:00
Conversation 2 Commits 1 Files changed 2 +3 -3
acid-ant commented 2023-03-14 08:01:30 +00:00
Member
Copy link

Close #14

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #14 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2023-03-14 08:01:32 +00:00 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from fyrchik 2023-03-14 08:02:08 +00:00
acid-ant requested review from dstepanov-yadro 2023-03-14 08:02:08 +00:00
acid-ant requested review from ale64bit 2023-03-14 08:02:08 +00:00
acid-ant requested review from alexvanin 2023-03-14 08:02:08 +00:00
acid-ant requested review from dkirillov 2023-03-14 08:02:08 +00:00
acid-ant requested review from carpawell 2023-03-14 08:02:14 +00:00
alexvanin approved these changes 2023-03-14 08:02:55 +00:00
alexvanin commented 2023-03-14 08:05:47 +00:00
Owner
Copy link

@acid-ant Are we going to change if isUpdate code in the contracts later or everything updates just fine already?

@acid-ant Are we going to change `if isUpdate` code in the contracts later or everything updates just fine already?
acid-ant commented 2023-03-14 08:40:44 +00:00
Author
Member
Copy link

@acid-ant Are we going to change if isUpdate code in the contracts later or everything updates just fine already?

Tested in dev-env with latest changes from master - everything looks good, adm morph update-contracts able to perform upgrade:

annikifa@annikiforov:~/workspace/frostfs-dev-env$ frostfs-adm morph update-contracts -r http://morph-chain.frostfs.devenv:30333 --contracts ../frostfs-contract --alphabet-wallets ../frostfs-dev-env/services/ir/ --verbose
Password for az wallet > 
Password for contract wallet > 
Waiting for transactions to persist...
NNS: Set group.frostfs -> 02b3622bf4017bdfe317c58aed5f4c753f206b7db896046fa7d774bbc4bf7f8dc2
Waiting for transactions to persist...
annikifa@annikiforov:~/workspace/frostfs-dev-env$
> @acid-ant Are we going to change `if isUpdate` code in the contracts later or everything updates just fine already? Tested in dev-env with latest changes from master - everything looks good, `adm morph update-contracts` able to perform upgrade: ``` annikifa@annikiforov:~/workspace/frostfs-dev-env$ frostfs-adm morph update-contracts -r http://morph-chain.frostfs.devenv:30333 --contracts ../frostfs-contract --alphabet-wallets ../frostfs-dev-env/services/ir/ --verbose Password for az wallet > Password for contract wallet > Waiting for transactions to persist... NNS: Set group.frostfs -> 02b3622bf4017bdfe317c58aed5f4c753f206b7db896046fa7d774bbc4bf7f8dc2 Waiting for transactions to persist... annikifa@annikiforov:~/workspace/frostfs-dev-env$ ```
fyrchik approved these changes 2023-03-14 09:03:05 +00:00
fyrchik merged commit 6b13a83736 into master 2023-03-14 09:03:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
ale64bit
dkirillov
carpawell
alexvanin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#15
No description provided.
Delete branch "acid-ant/frostfs-contract:bugfix/14-bump-contract-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?