Add iterator for container listing #33

New Issue

Closed

opened 2023-07-27 15:35:55 +00:00 by alexvanin · 3 comments

alexvanin commented

2023-07-27 15:35:55 +00:00

Owner

Some time ago, iterator for container estimation was added: 03bff785d2

Iterator allows to go through all items wihtout hitting the limit of the stack size. The same is applicable for List method, which returns owner's or all available container IDs.

Some time ago, iterator for container estimation was added: https://git.frostfs.info/TrueCloudLab/frostfs-contract/commit/03bff785d246759c2b7bfdfdd29872fda197d0b4 Iterator allows to go through all items wihtout hitting the limit of the stack size. The same is applicable for `List` method, which returns owner's or all available container IDs.

vdomnich-yadro self-assigned this 2023-07-28 07:25:52 +00:00

vdomnich-yadro commented

2023-08-02 05:39:09 +00:00

Collaborator

Done by @fyrchik in commit.

The method is still alive in the code

Done by @fyrchik in [commit](https://git.frostfs.info/TrueCloudLab/frostfs-contract/commit/4f3c08f5521af0ce397c1da522265cad3593ee15). The method is still alive in the [code](https://git.frostfs.info/vdomnich-yadro/frostfs-contract/src/branch/master/container/container_contract.go#L379)

vdomnich-yadro closed this issue

2023-08-02 05:39:09 +00:00

vdomnich-yadro reopened this issue

2023-08-02 05:43:00 +00:00

vdomnich-yadro commented

2023-08-02 05:44:06 +00:00

Collaborator

Actually, the existing method allows to iterate over container IDs only. Do we see a value in creating a method that would iterate over containers themselves, so that the client would not need to call getContainer for each ID?

vdomnich-yadro referenced this issue

2023-08-02 07:39:51 +00:00

[#33] Add IterateContainers method #34

fyrchik commented

2023-08-02 12:53:26 +00:00

Owner

I think doing getContainer on client is not that hard (and also could be done in parallel).
We would like to keep contract surface small, because supporting/updating contracts and having multi-version nodes coexisting in a single network is much easier.

I think doing `getContainer` on client is not that hard (and also could be done in parallel). We would like to keep contract surface small, because supporting/updating contracts and having multi-version nodes coexisting in a single network is much easier.

vdomnich-yadro closed this issue

2024-03-29 08:13:40 +00:00

vdomnich-yadro removed their assignment 2024-03-29 08:13:49 +00:00