TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 12 Pull requests 1 Projects Releases 2 Activity Actions

Make container.Delete() GAS cost more predictable #42

Merged
fyrchik merged 1 commit from fyrchik/frostfs-contract:fixed-marshal into support/v0.18 2024-09-04 19:51:17 +00:00
Conversation 0 Commits 1 Files changed 2 +13 -5
fyrchik commented 2023-10-05 12:04:10 +00:00
Owner
Copy link

Close #41.

Another way to fix this is to transform an integer by adding high bit.
We avoid additional struct delInfo, but there are 2 problems:

  1. Transformation is clumsy, because we work with big integers and Go compiler (not neo-go) can complain.
  2. Some big numbers can fail to be encoded, this is a bad API.
Close #41. Another way to fix this is to transform an integer by adding high bit. We avoid additional struct `delInfo`, but there are 2 problems: 1. Transformation is clumsy, because we work with big integers and Go compiler (not neo-go) can complain. 2. Some big numbers can fail to be encoded, this is a bad API.
fyrchik force-pushed fixed-marshal from 49df7b3c50 to 851c31d9b3 2023-10-05 12:09:52 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-10-05 12:10:09 +00:00
fyrchik requested review from storage-core-developers 2023-10-05 12:10:09 +00:00
fyrchik requested review from storage-services-committers 2023-10-05 12:10:11 +00:00
fyrchik requested review from storage-services-developers 2023-10-05 12:10:11 +00:00
fyrchik force-pushed fixed-marshal from 851c31d9b3 to ab18177e45 2023-10-05 12:10:17 +00:00 Compare
fyrchik changed title from Make container.Delete() GAS cost more predictable to Make container.Delete() GAS cost more predictable 2023-10-05 12:13:27 +00:00
fyrchik changed target branch from master to support/v0.18 2023-10-05 12:13:28 +00:00
JuliaKovshova approved these changes 2023-10-05 12:13:55 +00:00
dstepanov-yadro approved these changes 2023-10-05 12:15:09 +00:00
fyrchik force-pushed fixed-marshal from ab18177e45 to 6212b5bf72 2023-10-05 12:50:54 +00:00 Compare
alexvanin approved these changes 2023-10-05 12:54:17 +00:00
acid-ant approved these changes 2023-10-05 13:19:40 +00:00
fyrchik merged commit 6212b5bf72 into support/v0.18 2023-10-05 14:39:42 +00:00
fyrchik deleted branch fixed-marshal 2023-10-05 14:39:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
JuliaKovshova
dstepanov-yadro
alexvanin
acid-ant
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#42
No description provided.
Delete branch "fyrchik/frostfs-contract:fixed-marshal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?