TrueCloudLab
/
frostfs-contract
21
0
Fork 16
Code Issues 9 Pull Requests 1 Actions Releases 2 Activity

Generate RPC bindings to contracts #47

Merged
fyrchik merged 2 commits from fyrchik/frostfs-contract:generate-wrappers into master 2023-10-31 10:28:39 +00:00
Conversation 1 Commits 2 Files Changed 14
fyrchik commented 2023-10-24 16:52:11 +00:00
Owner
There is no content yet.
fyrchik added the
discussion
 label 2023-10-24 16:52:11 +00:00
fyrchik requested review from storage-core-committers 2023-10-24 16:52:22 +00:00
fyrchik requested review from storage-core-developers 2023-10-24 16:52:23 +00:00
fyrchik requested review from storage-services-committers 2023-10-24 16:52:25 +00:00
fyrchik requested review from storage-services-developers 2023-10-24 16:52:26 +00:00
fyrchik force-pushed generate-wrappers from 185bdbbaf9 to 6b1e2d48ff 2023-10-24 18:55:41 +00:00 Compare
fyrchik force-pushed generate-wrappers from 6b1e2d48ff to 756c14a3ba 2023-10-24 19:23:40 +00:00 Compare
dstepanov-yadro reviewed 2023-10-26 07:22:25 +00:00
rpcclient/alphabet/client.go Outdated
@ -0,0 +1,136 @@
// Package alphabet contains RPC wrappers for Alphabet contract.
dstepanov-yadro commented 2023-10-26 07:22:23 +00:00
Collaborator

Are all of this files generated? Is it neo-go bug, that there is no Code generated comment?
From https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source

To convey to humans and machine tools that code is generated, generated source should have a line that matches the following regular expression (in Go syntax):

^// Code generated .* DO NOT EDIT\.$
Are all of this files generated? Is it neo-go bug, that there is no `Code generated` comment? From https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source ``` To convey to humans and machine tools that code is generated, generated source should have a line that matches the following regular expression (in Go syntax): ^// Code generated .* DO NOT EDIT\.$ ```
fyrchik commented 2023-10-26 10:25:23 +00:00
Poster
Owner

It is a known issue https://github.com/nspcc-dev/neo-go/issues/3139 (neo-go is not yes updated, will fix)

It is a known issue https://github.com/nspcc-dev/neo-go/issues/3139 (neo-go is not yes updated, will fix)
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro approved these changes 2023-10-26 15:42:29 +00:00
fyrchik force-pushed generate-wrappers from 756c14a3ba to a7948d8c14 2023-10-27 08:45:30 +00:00 Compare
fyrchik force-pushed generate-wrappers from a7948d8c14 to bbb56aa035 2023-10-27 08:45:42 +00:00 Compare
fyrchik commented 2023-10-27 08:45:46 +00:00
Poster
Owner

Updated neo-go, now with gofmt and auto-generated warning

Updated neo-go, now with gofmt and auto-generated warning
dkirillov approved these changes 2023-10-30 06:35:45 +00:00
acid-ant approved these changes 2023-10-30 10:13:40 +00:00
Makefile Outdated
@ -52,0 +56,4 @@
@# but this leads to a large amount of code duplication. It can be written by hand,
@# in case we need to override the type of some variables.
@# --config $*/$*.bindings.yml
@# Unfortunately, primitive integer types are not yes supported.
acid-ant commented 2023-10-30 10:12:18 +00:00
Collaborator

Typo yes -> yet.

Typo yes -> yet.
fyrchik commented 2023-10-31 10:28:35 +00:00
Poster
Owner

fixed

fixed
aarifullin approved these changes 2023-10-30 11:01:57 +00:00
fyrchik force-pushed generate-wrappers from bbb56aa035 to 1314cc38f6 2023-10-30 14:39:38 +00:00 Compare
dkirillov approved these changes 2023-10-30 14:44:21 +00:00
fyrchik merged commit 901d5a4083 into master 2023-10-31 10:28:39 +00:00
fyrchik deleted branch generate-wrappers 2023-10-31 10:28:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
aarifullin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#47
There is no content yet.
Delete Branch "fyrchik/frostfs-contract:generate-wrappers"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?