TrueCloudLab
/
frostfs-contract
21
0
Fork 16
Code Issues 9 Pull Requests 2 Actions Releases 2 Activity

Small fixes for frostfsid, policy contracts #55

Merged
fyrchik merged 9 commits from fyrchik/frostfs-contract:frostfsid-admin into master 2023-11-29 07:37:14 +00:00
Conversation 0 Commits 9 Files Changed 10
fyrchik commented 2023-11-28 09:31:35 +00:00
Owner

Close #54.

Close #54.
fyrchik changed title from frostfsid-admin to Small fixes for frostfsid, policy contracts 2023-11-28 09:31:47 +00:00
fyrchik force-pushed frostfsid-admin from 362bb968fb to 3c38acea63 2023-11-28 09:32:43 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-11-28 09:32:48 +00:00
fyrchik requested review from storage-core-developers 2023-11-28 09:32:48 +00:00
fyrchik requested review from storage-services-committers 2023-11-28 09:32:54 +00:00
fyrchik requested review from storage-services-developers 2023-11-28 09:33:00 +00:00
dkirillov approved these changes 2023-11-28 10:20:43 +00:00
dkirillov left a comment
Collaborator

Can we also fix typo
Should be ErrNotAuthorized I suppose.

Can we also [fix typo](https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/e56e8d02eee3f6aa35807760610b2bdc5970bd22/policy/policy_contract.go#L28) Should be `ErrNotAuthorized` I suppose.
👍 1
frostfsid/config.yml Outdated
@ -2,1 +2,3 @@
safemethods: ["version"]
safemethods:
- "version"
- "getAdmin"
dkirillov commented 2023-11-28 10:19:12 +00:00
Collaborator

Maybe we can add here all read-only methods so the generated client wrapper can handle this method properly (I meand for example for GetSubject method wrapper will return []stackitem.Item then, now this method looks like write one)

Maybe we can add here all read-only methods so the generated client wrapper can handle this method properly (I meand for example for `GetSubject` method wrapper will return `[]stackitem.Item` then, now this method [looks like write one](https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/e56e8d02eee3f6aa35807760610b2bdc5970bd22/rpcclient/frostfsid/client.go#L548))
fyrchik commented 2023-11-28 10:56:13 +00:00
Poster
Owner

fixed

fixed
dkirillov marked this conversation as resolved
fyrchik force-pushed frostfsid-admin from 3c38acea63 to 00122e8372 2023-11-28 10:54:12 +00:00 Compare
fyrchik force-pushed frostfsid-admin from 00122e8372 to 70746d1a1e 2023-11-28 10:56:17 +00:00 Compare
dkirillov reviewed 2023-11-28 11:42:18 +00:00
policy/policy_contract.go Outdated
@ -27,2 +26,3 @@
// ErrNotAuthorized is returned when the none of the transaction signers
// belongs to the list of autorized keys.
ErrNotAutorized = "none of the signers is not autorized to change the contract"
ErrNotAuthorized = "none of the signers is autorized to change the contract"
dkirillov commented 2023-11-28 11:42:18 +00:00
Collaborator

ErrNotAuthorized = "none of the signers is autorized to change the contract"
vs
ErrNotAuthorized = "none of the signers is authorized to change the contract" (typo in text also)

`ErrNotAuthorized = "none of the signers is autorized to change the contract"` vs `ErrNotAuthorized = "none of the signers is authorized to change the contract"` (typo in text also)
fyrchik commented 2023-11-29 06:22:06 +00:00
Poster
Owner

Fixed

Fixed
dkirillov commented 2023-11-29 06:37:16 +00:00
Collaborator

I'm not sure 8d7d2de4a4/policy/policy_contract.go (L28) 🙈

I'm not sure https://git.frostfs.info/fyrchik/frostfs-contract/src/commit/8d7d2de4a4a681ae6226fddf3a57accf54d86820/policy/policy_contract.go#L28 🙈
fyrchik commented 2023-11-29 06:38:52 +00:00
Poster
Owner

forgot to push, fixed now

forgot to push, fixed now
👍 1
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-11-28 11:42:25 +00:00
dstepanov-yadro approved these changes 2023-11-28 15:05:02 +00:00
fyrchik force-pushed frostfsid-admin from 8d7d2de4a4 to a1b61d3949 2023-11-29 06:38:41 +00:00 Compare
dkirillov approved these changes 2023-11-29 06:41:42 +00:00
fyrchik merged commit a1b61d3949 into master 2023-11-29 07:37:14 +00:00
fyrchik referenced this issue from a commit 2023-11-29 07:37:15 +00:00
[#55] Apply gofumpt
fyrchik deleted branch frostfsid-admin 2023-11-29 07:37:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#55
There is no content yet.
Delete Branch "fyrchik/frostfs-contract:frostfsid-admin"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?