TrueCloudLab/frostfs-contract
22
0
Fork 17
Code Issues 12 Pull requests 2 Projects Releases 2 Activity Actions

frostfsid: Remove old data on update #95

Merged
fyrchik merged 1 commit from fyrchik/frostfs-contract:fix-frostfsid-update into support/v0.19 2024-09-04 19:51:18 +00:00
Conversation 0 Commits 1 Files changed 2 +2 -2
fyrchik commented 2024-06-04 08:31:07 +00:00
Owner
Copy link
No description provided.
fyrchik force-pushed fix-frostfsid-update from 37f8b49b22 to 05a7545d93 2024-06-04 08:31:26 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-06-04 08:31:27 +00:00
fyrchik requested review from storage-core-developers 2024-06-04 08:31:28 +00:00
fyrchik requested review from storage-services-committers 2024-06-04 08:31:29 +00:00
fyrchik requested review from storage-services-developers 2024-06-04 08:31:29 +00:00
dkirillov reviewed 2024-06-04 08:34:30 +00:00
frostfsid/frostfsid_contract.go Outdated
@ -75,1 +75,4 @@
if isUpdate {
storage.Delete(ctx, "netmapScriptHash")
storage.Delete(ctx, "containerScriptHash")
dkirillov commented 2024-06-04 08:34:26 +00:00
Member
Copy link

Should we also delete notary key and o prefix?

Should we also delete `notary` key and `o` prefix?
fyrchik commented 2024-06-04 08:42:20 +00:00
Author
Owner
Copy link

I believe notary was actually removed during the previous update (see support/v0.18 branch)
Added o prefix removal.

I believe `notary` was actually removed during the previous update (see support/v0.18 branch) Added `o` prefix removal.
dkirillov commented 2024-06-04 09:35:18 +00:00
Member
Copy link

I don't see we explicitly deleted such key https://git.frostfs.info/TrueCloudLab/frostfs-contract/pulls/50/files#diff-0854a7a4bf47e1957519dccfa5d54a2c5c8d08ee

Or we just didn't set it?

I don't see we explicitly deleted such key https://git.frostfs.info/TrueCloudLab/frostfs-contract/pulls/50/files#diff-0854a7a4bf47e1957519dccfa5d54a2c5c8d08ee Or we just didn't set it?
fyrchik commented 2024-06-04 10:54:55 +00:00
Author
Owner
Copy link

common.RmAndCheckNotaryDisabledKey(data, notaryDisabledKey) -- this line was present in the previous release.

`common.RmAndCheckNotaryDisabledKey(data, notaryDisabledKey)` -- this line was present in the previous release.
👍 1
dkirillov marked this conversation as resolved
fyrchik force-pushed fix-frostfsid-update from 05a7545d93 to fec6e23c58 2024-06-04 08:35:12 +00:00 Compare
fyrchik force-pushed fix-frostfsid-update from fec6e23c58 to b4ad90507e 2024-06-04 08:40:43 +00:00 Compare
alexvanin approved these changes 2024-06-04 08:45:49 +00:00
elebedeva approved these changes 2024-06-04 08:47:57 +00:00
achuprov approved these changes 2024-06-04 08:57:25 +00:00
acid-ant approved these changes 2024-06-04 09:00:59 +00:00
dkirillov approved these changes 2024-06-04 09:31:28 +00:00
fyrchik merged commit b4ad90507e into support/v0.19 2024-06-04 10:54:27 +00:00
fyrchik deleted branch fix-frostfsid-update 2024-06-04 10:54:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
elebedeva
achuprov
acid-ant
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#95
No description provided.
Delete branch "fyrchik/frostfs-contract:fix-frostfsid-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?