TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 13 Pull requests 1 Projects Releases 2 Activity Actions

frostfsid: Restrict keys to a single subject #123

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:bugfix/restrict_primary_key into master 2024-11-14 12:24:05 +00:00
Conversation 1 Commits 1 Files changed 3 +79
achuprov commented 2024-10-30 15:02:46 +00:00
Member
Copy link

Close #118
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #118 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-10-30 15:02:46 +00:00
[#118] frostfsid: Restrict keys to a single subject
All checks were successful
DCO action / DCO (pull_request) Successful in 43s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m30s
Details
Tests / Tests (pull_request) Successful in 1m33s
Details
71bb3a65b7 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed bugfix/restrict_primary_key from 71bb3a65b7 to a98caa7210 2024-10-30 15:03:38 +00:00 Compare
fyrchik reviewed 2024-10-31 06:55:59 +00:00
tests/frostfsid_test.go Outdated
@ -604,6 +604,44 @@ func TestFrostFSID_GroupManagement(t *testing.T) {
})
}
func TestAdditionalKeyFromPrimarySubject(t *testing.T) {
fyrchik commented 2024-10-31 06:55:59 +00:00
Owner
Copy link

@achuprov have you used coverage to see whether test covers everything you have written?

@achuprov have you used coverage to see whether test covers everything you have written?
achuprov commented 2024-11-08 14:25:28 +00:00
Author
Member
Copy link

Yes, all modified branches are covered by tests. Test coverage is 83% for Frostfid and 86% for NNS.

Yes, all modified branches are covered by tests. Test coverage is 83% for `Frostfid` and 86% for `NNS`.
fyrchik marked this conversation as resolved
aarifullin reviewed 2024-10-31 07:38:59 +00:00
frostfsid/frostfsid_contract.go Outdated
@ -97,2 +97,4 @@
groupCounterKey = 'c'
namespaceGroupsNamesPrefix = 'm'
// allAddressPrefix contains all keys and signifies that the key has been used.
allAddressPrefix = 'A'
aarifullin commented 2024-10-31 07:38:59 +00:00
Member
Copy link

Please, add this prefix to scheme within doc.go

Please, add this prefix to scheme within `doc.go`
👍 1
achuprov commented 2024-11-08 14:26:00 +00:00
Author
Member
Copy link

added

added
achuprov force-pushed bugfix/restrict_primary_key from a98caa7210 to 68e011efce 2024-11-08 08:12:51 +00:00 Compare
achuprov force-pushed bugfix/restrict_primary_key from 68e011efce to 874a8cc321 2024-11-08 14:18:25 +00:00 Compare
acid-ant reviewed 2024-11-11 05:59:53 +00:00
frostfsid/frostfsid_contract.go Outdated
@ -215,1 +222,4 @@
addressKey := addressKey(contract.CreateStandardAccount(key))
if storage.Get(ctx, addressKey) != nil {
panic("key is occupied")
acid-ant commented 2024-11-11 05:59:52 +00:00
Member
Copy link

Can the error message be more specific?

Can the error message be more specific?
acid-ant approved these changes 2024-11-11 06:00:07 +00:00
Dismissed
fyrchik approved these changes 2024-11-11 08:17:13 +00:00
Dismissed
fyrchik commented 2024-11-11 08:17:23 +00:00
Owner
Copy link

What about migration?

What about migration?
aarifullin approved these changes 2024-11-11 08:29:55 +00:00
Dismissed
achuprov force-pushed bugfix/restrict_primary_key from 874a8cc321 to e47a12f3a6 2024-11-13 18:29:33 +00:00 Compare
achuprov dismissed acid-ant's review 2024-11-13 18:29:33 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed fyrchik's review 2024-11-13 18:29:33 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed aarifullin's review 2024-11-13 18:29:33 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov force-pushed bugfix/restrict_primary_key from e47a12f3a6 to 7a8c64b966 2024-11-13 18:35:28 +00:00 Compare
acid-ant approved these changes 2024-11-14 06:12:54 +00:00
fyrchik approved these changes 2024-11-14 12:23:36 +00:00
fyrchik merged commit 7a8c64b966 into master 2024-11-14 12:24:05 +00:00
alexvanin approved these changes 2024-11-14 14:04:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#123
No description provided.
Delete branch "achuprov/frostfs-contract:bugfix/restrict_primary_key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?