TrueCloudLab/frostfs-dev-env
40
0
Fork 17
Code Issues 15 Pull requests 1 Releases Activity Actions

Tracing: add jaeger and fix service configs #13

Merged
alexvanin merged 1 commit from dstepanov-yadro/frostfs-dev-env:feat/tracing into master 2023-03-20 10:15:29 +00:00
Conversation 0 Commits 1 Files changed 7 +37
dstepanov-yadro commented 2023-03-13 11:45:55 +00:00
Member
Copy link
No description provided.
dstepanov-yadro force-pushed feat/tracing from 22a2fef00f to 3a6519e2f4 2023-03-15 08:30:02 +00:00 Compare
dstepanov-yadro force-pushed feat/tracing from 3a6519e2f4 to 2e3b3e401c 2023-03-17 09:17:22 +00:00 Compare
dstepanov-yadro changed title from WIP: [#XX] dev-env: Tracing to Tracing: add jaeger and fix service configs 2023-03-17 09:22:08 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-03-17 09:22:27 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-03-17 09:22:28 +00:00
acid-ant approved these changes 2023-03-17 09:49:36 +00:00
alexvanin reviewed 2023-03-17 10:18:24 +00:00
services/http_gate/cfg/config.yml Outdated
@ -21,0 +23,4 @@
tracing:
enabled: true
exporter: otlp_grpc
endpoint: "192.168.130.120:4317"
alexvanin commented 2023-03-17 10:18:24 +00:00
Owner
Copy link

I would rather update configs together with image version. Maybe we will change configuration format a bit before merge?

Speaking of config format, just wonder, how configuration is going to look when service dumps trace into the file? Is it new exporter constant?

I would rather update configs together with image version. Maybe we will change configuration format a bit before merge? Speaking of config format, just wonder, how configuration is going to look when service dumps trace into the file? Is it new `exporter` constant?
dstepanov-yadro commented 2023-03-17 15:35:09 +00:00
Author
Member
Copy link

yes, it will be new exporter

output to standard output is also currently supported. In this case, the config looks like this:

tracing:
  enabled: true
  exporter: "stdout"
yes, it will be new `exporter` output to standard output is also currently supported. In this case, the config looks like this: ``` tracing: enabled: true exporter: "stdout" ```
dstepanov-yadro commented 2023-03-17 15:41:00 +00:00
Author
Member
Copy link

reverted config file changes

reverted config file changes
dstepanov-yadro force-pushed feat/tracing from 2e3b3e401c to 93435bfb63 2023-03-17 15:39:59 +00:00 Compare
alexvanin approved these changes 2023-03-20 10:15:21 +00:00
alexvanin merged commit 93435bfb63 into master 2023-03-20 10:15:29 +00:00
alexvanin referenced this pull request from a commit 2023-03-20 10:15:29 +00:00
[#13] dev-env: Add tracing support
alexvanin deleted branch feat/tracing 2023-03-20 10:15:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
alexvanin
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#13
No description provided.
Delete branch "dstepanov-yadro/frostfs-dev-env:feat/tracing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?