Restore `.env` version format #78

New issue

Closed

opened 2024-08-20 08:34:43 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-08-20 08:34:43 +00:00

Owner

Consider the following diff from #76:

-IR_VERSION=0.38.5
-IR_IMAGE=truecloudlab/frostfs-ir
+IR_VERSION=v0.42.9
+IR_IMAGE=git.frostfs.info/truecloudlab/frostfs-ir

It changes the format of the values, notice the leading v in version and git.frostfs.info/ in the image.
The version is different from that of make image target in the frostfs-node.
We need to restore the old format.
As for git.frostfs.info, we may explicitly include registry variable or leave as is.
But it is a bit annoying to remove git.frostfs.info/ when trying to replace it with a dirty image.

Consider the following diff from #76: ```diff -IR_VERSION=0.38.5 -IR_IMAGE=truecloudlab/frostfs-ir +IR_VERSION=v0.42.9 +IR_IMAGE=git.frostfs.info/truecloudlab/frostfs-ir ``` It changes the format of the values, notice the leading `v` in version and `git.frostfs.info/` in the image. The version is different from that of `make image` target in the frostfs-node. We need to restore the old format. As for `git.frostfs.info`, we may explicitly include registry variable or leave as is. But it is a bit annoying to remove `git.frostfs.info/` when trying to replace it with a dirty image.