TrueCloudLab/frostfs-dev-env
41
0
Fork 17
Code Issues 14 Pull requests 1 Releases Activity Actions

Makefile: Add subjects for storage and client wallets to FrostfsID #75

Merged
fyrchik merged 1 commit from aarifullin/frostfs-dev-env:feat/fidsubj_makefile into master 2024-08-16 07:46:12 +00:00
Conversation 0 Commits 1 Files changed 1 +6 -1
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d03be14312 - Show all commits

7
Makefile
View file

@ -85,7 +85,12 @@ up/bootstrap: get vendor/hosts
&& ./vendor/frostfs-adm -c frostfs-adm.yml morph refill-gas --storage-wallet $${f} --gas 10.0 \ && ./vendor/frostfs-adm -c frostfs-adm.yml morph refill-gas --storage-wallet $${f} --gas 10.0 \
|| die "Failed to transfer GAS to alphabet wallets"; \ || die "Failed to transfer GAS to alphabet wallets"; \
done done
@echo "FrostFS sidechain environment is deployed" @echo "Create frostfsid subject for ./wallets/wallet.json" \
fyrchik commented 2024-08-02 12:55:56 +00:00
Outdated
Review
Copy link

I think storage nodes are ok not being in the frostfsid, we have user wallet for containers.

I think storage nodes are ok not being in the frostfsid, we have user wallet for containers.
aarifullin commented 2024-08-02 13:30:52 +00:00
Outdated
Review
Copy link

OK.

But still WDYT about neo-go?

OK. But still WDYT about `neo-go`?
fyrchik commented 2024-08-05 12:34:45 +00:00
Outdated
Review
Copy link

using neo-go is more robust than jq + tail c+3

using neo-go is more robust than `jq + tail c+3`
aarifullin commented 2024-08-08 10:19:11 +00:00
Outdated
Review
Copy link

Got neo-go away, please, check

Got `neo-go` away, please, check
fyrchik commented 2024-08-08 10:31:43 +00:00
Outdated
Review
Copy link

Why, though? "robust" is a good thing.

Why, though? "robust" is a good thing.
dstepanov-yadro commented 2024-08-08 13:42:22 +00:00
Outdated
Review
Copy link

Then neo-go should be vendored.

Then neo-go should be vendored.
aarifullin commented 2024-08-08 14:01:45 +00:00
Outdated
Review
Copy link
  1. I mistook "robust" for "giant" but you problably meant "sturdy"
  2. @dstepanov-yadro is right. In this case we need to introduce neo-go binary in .env along with
...
# FrostFS ADM tool binary
FROSTFS_ADM_VERSION=498f9955ea
FROSTFS_ADM_URL=https://http.t5.fs.neo.org/7sm9csjtRLpr4c9QD55q9JJM73v79ohuAhTzP4fYRHFz/CjV4S6ENzo2FLK4KxXZHHNW4veR1ATtynGY6Mc1xQ6RB
#FROSTFS_ADM_PATH=/path/to/frostfs-adm-binary
...

to get it vendored

So, we need to upload it to somewhere. Once, we had a discussion and we didn't agree on uploading to http.t5.fs.neo.org (I may mistake)

1. I mistook "robust" for "giant" but you problably meant "sturdy" 2. @dstepanov-yadro is right. In this case we need to introduce `neo-go` binary in `.env` along with ```bash ... # FrostFS ADM tool binary FROSTFS_ADM_VERSION=498f9955ea FROSTFS_ADM_URL=https://http.t5.fs.neo.org/7sm9csjtRLpr4c9QD55q9JJM73v79ohuAhTzP4fYRHFz/CjV4S6ENzo2FLK4KxXZHHNW4veR1ATtynGY6Mc1xQ6RB #FROSTFS_ADM_PATH=/path/to/frostfs-adm-binary ... ``` to get it vendored So, we need to upload it to *somewhere*. Once, we had a discussion and we didn't agree on uploading to `http.t5.fs.neo.org` (I may mistake)
fyrchik commented 2024-08-08 14:09:54 +00:00
Outdated
Review
Copy link

We already have a docker image for neo-go, right?
Can we use it?

We already have a docker image for neo-go, right? Can we use it?
👀 1
aarifullin commented 2024-08-09 13:45:14 +00:00
Outdated
Review
Copy link

We already have a docker image for neo-go, right?

That's really a brilliant idea. Fixed that

> We already have a docker image for neo-go, right? That's really a brilliant idea. Fixed that
&& subj_key=`docker container exec -it morph_chain neo-go wallet dump-keys -w /wallets/wallet.json | tail -1 | tr -d ' \r\n'` \
&& echo "Subject key: $${subj_key}" \
&& ./vendor/frostfs-adm -c frostfs-adm.yml morph frostfsid create-subject --namespace "" --subject-key $${subj_key} --subject-name walletsubject \
|| die "Failed to create subject for the wallet"; \
echo "FrostFS sidechain environment is deployed"
aarifullin marked this conversation as resolved Outdated
aarifullin commented 2024-08-02 12:02:41 +00:00
Outdated
Review
Copy link

We've got no neo-go in .vendor. So, it assumes that neo-go is installed separately.
Probably, this is not right for frostfs-dev-env bootup

The alternative way to get parsed script is:

cat wallets/wallet.json | jq -r '.accounts[0].contract.script' | base64 -d | tail -c+3 | xxd -p

(returns the same result)

WDYT?

We've got no `neo-go` in `.vendor`. So, it assumes that `neo-go` is installed separately. Probably, this is not right for `frostfs-dev-env` bootup The alternative way to get parsed script is: ``` cat wallets/wallet.json | jq -r '.accounts[0].contract.script' | base64 -d | tail -c+3 | xxd -p ``` (returns the same result) WDYT?
dstepanov-yadro commented 2024-08-02 15:19:29 +00:00
Outdated
Review
Copy link

FrostfID subject is required to create containers. Neo-go or Frostfs-storage should not to create containers. So their wallets are not required to be stored in FrostfsID contract.

FrostfID subject is required to create containers. Neo-go or Frostfs-storage should not to create containers. So their wallets are not required to be stored in FrostfsID contract.
aarifullin commented 2024-08-05 09:44:53 +00:00
Outdated
Review
Copy link

Okay, I'll leave it only for client wallet. But the problem is that we need to get a subject key for this wallet

Okay, I'll leave it only for client wallet. But the problem is that we need to get a subject key for this wallet
aarifullin commented 2024-08-08 10:18:51 +00:00
Outdated
Review
Copy link

Fixed

Fixed
# Build up certain service # Build up certain service
.PHONY: up/% .PHONY: up/%