From 1d82686b8edbe6c0dee6399a898cf26367e77036 Mon Sep 17 00:00:00 2001
From: Pavel Pogodaev
Date: Wed, 16 Apr 2025 17:53:49 +0300
Subject: [PATCH] [#230] Refactor logger tag configuration
Signed-off-by: Pavel Pogodaev
---
cmd/http-gw/app.go | 10 ++--------
cmd/http-gw/logger.go | 6 ++----
cmd/http-gw/settings.go | 1 -
3 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/cmd/http-gw/app.go b/cmd/http-gw/app.go
index ca7797f..e1ead5f 100644
--- a/cmd/http-gw/app.go
+++ b/cmd/http-gw/app.go
@@ -198,17 +198,11 @@ func (t *tagsConfig) update(cfg *viper.Viper, ll zapcore.Level) error {
return err
}
- t.tagLogs.Range(func(key, value any) bool {
+ t.tagLogs.Range(func(key, _ any) bool {
k := key.(string)
- v := value.(zapcore.Level)
- if lvl, ok := tags[k]; ok {
- if lvl != v {
- t.tagLogs.Store(key, lvl)
- }
- } else {
+ if _, ok := tags[k]; !ok {
t.tagLogs.Delete(key)
- delete(tags, k)
}
return true
})
diff --git a/cmd/http-gw/logger.go b/cmd/http-gw/logger.go
index 195aa4e..196cff3 100644
--- a/cmd/http-gw/logger.go
+++ b/cmd/http-gw/logger.go
@@ -40,7 +40,7 @@ type zapCoreTagFilterWrapper struct {
}
type TagFilterSettings interface {
- LevelEnabled(tag string, tgtLevel zapcore.Level) bool
+ LevelEnabled(tag string, lvl zapcore.Level) bool
DefaultEnabled(lvl zapcore.Level) bool
}
@@ -130,14 +130,13 @@ func newLogEncoder() zapcore.Encoder {
//
// See also zapcore.Level, zap.NewProductionConfig, zap.AddStacktrace.
func newStdoutLogger(v *viper.Viper, lvl zap.AtomicLevel, loggerSettings LoggerAppSettings, tagSetting TagFilterSettings) *Logger {
- stdout := zapcore.AddSync(os.Stderr)
+ stdout := zapcore.AddSync(os.Stdout)
consoleOutCore := zapcore.NewCore(newLogEncoder(), stdout, lvl)
consoleOutCore = applyZapCoreMiddlewares(consoleOutCore, v, loggerSettings, tagSetting)
return &Logger{
logger: zap.New(consoleOutCore, zap.AddStacktrace(zap.NewAtomicLevelAt(zap.FatalLevel))),
- lvl: lvl,
}
}
@@ -155,7 +154,6 @@ func newJournaldLogger(v *viper.Viper, lvl zap.AtomicLevel, loggerSettings Logge
return &Logger{
logger: zap.New(coreWithContext, zap.AddStacktrace(zap.NewAtomicLevelAt(zap.FatalLevel))),
- lvl: lvl,
}
}
diff --git a/cmd/http-gw/settings.go b/cmd/http-gw/settings.go
index 982b401..814a14e 100644
--- a/cmd/http-gw/settings.go
+++ b/cmd/http-gw/settings.go
@@ -208,7 +208,6 @@ var defaultTags = []string{logs.TagApp, logs.TagDatapath, logs.TagExternalStorag
type Logger struct {
logger *zap.Logger
- lvl zap.AtomicLevel
}
type appCfg struct {