TrueCloudLab
/
frostfs-http-gw
15
0
Fork 12
Code Issues 5 Pull Requests 1 Actions Releases 4 Activity

feature/add_mocks #117

Merged
alexvanin merged 2 commits from dkirillov/frostfs-http-gw:feature/add_mocks into master 2024-06-18 13:22:16 +00:00
Conversation 0 Commits 2 Files Changed 13
dkirillov commented 2024-06-17 14:57:56 +00:00
Collaborator
There is no content yet.
dkirillov self-assigned this 2024-06-17 14:57:56 +00:00
dkirillov added 2 commits 2024-06-17 14:57:58 +00:00
70908e7be0 [#XX] Fix integration test after updating dependencies 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
/ DCO (pull_request) Failing after 1m41s Details
/ Builds (1.21) (pull_request) Successful in 2m17s Details
/ Builds (1.22) (pull_request) Successful in 1m37s Details
/ Vulncheck (pull_request) Successful in 2m34s Details
/ Lint (pull_request) Failing after 4m47s Details
/ Tests (1.21) (pull_request) Successful in 3m17s Details
/ Tests (1.22) (pull_request) Successful in 3m12s Details
4270140663 [#XX] Add mocked handler for tests 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed feature/add_mocks from 4270140663 to 7b49e81e0b 2024-06-17 14:58:48 +00:00 Compare
dkirillov force-pushed feature/add_mocks from 7b49e81e0b to 98c43c74a3 2024-06-18 06:28:15 +00:00 Compare
dkirillov changed title from WIP: feature/add_mocks to feature/add_mocks 2024-06-18 06:49:58 +00:00
dkirillov requested review from storage-services-committers 2024-06-18 06:50:06 +00:00
dkirillov requested review from storage-services-developers 2024-06-18 06:50:06 +00:00
alexvanin reviewed 2024-06-18 07:55:21 +00:00
internal/frostfs/frostfs.go Outdated
@ -0,0 +32,4 @@
}
// Container implements frostfs.FrostFS interface method.
func (x *FrostFS) Container(ctx context.Context, layerPrm handler.PrmContainer) (*container.Container, error) {
alexvanin commented 2024-06-18 07:47:05 +00:00
Owner

We keep parameter definition outside of this package so FrostFS interface can be defined without import of this package, right?

We keep parameter definition outside of this package so `FrostFS` interface can be defined without import of this package, right?
dkirillov commented 2024-06-18 08:27:22 +00:00
Poster
Collaborator

Right

Right
alexvanin marked this conversation as resolved
internal/handler/frostfs_mock.go Outdated
@ -0,0 +130,4 @@
// }
//
// return res, nil
// }
alexvanin commented 2024-06-18 07:36:25 +00:00
Owner

Unused?

Unused?
👀 1
alexvanin marked this conversation as resolved
internal/handler/frostfs_mock.go Outdated
@ -0,0 +227,4 @@
// }
//
// return nil
//}
alexvanin commented 2024-06-18 07:55:05 +00:00
Owner

Unused?

Unused?
alexvanin marked this conversation as resolved
internal/handler/frostfs_mock.go Outdated
@ -0,0 +351,4 @@
// }
//
// return table, nil
//}
alexvanin commented 2024-06-18 07:36:38 +00:00
Owner

Unused?

Unused?
alexvanin marked this conversation as resolved
internal/handler/frostfs_mock.go Outdated
@ -0,0 +368,4 @@
return true
}
for _, rec := range table.Records() {
alexvanin commented 2024-06-18 07:54:40 +00:00
Owner

Can we simplify access check somehow so we won't depend on eACL? Maybe we can define a list of cnr + owner + op + objID tuples which are allowed and all others are denied?

Can we simplify access check somehow so we won't depend on eACL? Maybe we can define a list of `cnr + owner + op + objID` tuples which are allowed and all others are denied?
👍 1
alexvanin marked this conversation as resolved
internal/handler/handler.go Outdated
@ -36,2 +35,4 @@
}
// PrmContainer groups parameters of FrostFS.Container operation.
type PrmContainer struct {
alexvanin commented 2024-06-18 07:49:18 +00:00
Owner

What you think about having separate go file for frostfs interface and parameter definitions? frostfs.go and frostfs_mock.go looks good in my opinion.

What you think about having separate go file for frostfs interface and parameter definitions? `frostfs.go` and `frostfs_mock.go` looks good in my opinion.
dkirillov commented 2024-06-18 08:31:30 +00:00
Poster
Collaborator

It isn't so big to move this to separate file I suppose

It isn't so big to move this to separate file I suppose
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/add_mocks from 98c43c74a3 to 3741e3b003 2024-06-18 09:04:31 +00:00 Compare
alexvanin approved these changes 2024-06-18 13:22:06 +00:00
alexvanin merged commit 3741e3b003 into master 2024-06-18 13:22:16 +00:00
alexvanin deleted branch feature/add_mocks 2024-06-18 13:22:20 +00:00
alexvanin referenced this issue from a commit 2024-06-25 15:12:23 +00:00
[#117] Update tests
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dkirillov
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#117
There is no content yet.
Delete Branch "dkirillov/frostfs-http-gw:feature/add_mocks"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?