TrueCloudLab/frostfs-http-gw

Support CORs #158

New issue

Closed

opened 2024-10-23 13:15:44 +00:00 by dkirillov · 1 comment

dkirillov commented

2024-10-23 13:15:44 +00:00

Member

To support HLS https://git.frostfs.info/dkirillov/frostfs-http-gw/src/branch/poc/hls we need http-gw supports CORs headers

Describe the solution you'd like

We can add new config params to support CORs
For example:

cors:
  enabled: false
  origin: ["*"]
  methods: ["GET"]
  headers: ["Authorization"]

Describe alternatives you've considered

Don't add cors at all
Unconditionally add cors

Additional context

No

## Is your feature request related to a problem? Please describe. To support HLS https://git.frostfs.info/dkirillov/frostfs-http-gw/src/branch/poc/hls we need http-gw supports CORs headers ## Describe the solution you'd like We can add new config params to support CORs For example: ```yaml cors: enabled: false origin: ["*"] methods: ["GET"] headers: ["Authorization"] ``` ## Describe alternatives you've considered * Don't add cors at all * Unconditionally add cors ## Additional context No

dkirillov was assigned by alexvanin

2024-10-24 07:36:30 +00:00

alexvanin commented

2024-10-24 07:39:05 +00:00

Owner

Enabled config option seems redundant for me, we can add it later. Empty origin, methods and headers options disable CORS anyway.

Enabled config option seems redundant for me, we can add it later. Empty `origin`, `methods` and `headers` options disable CORS anyway.

dkirillov referenced this issue from a pull request that will close it,

2024-10-24 14:28:30 +00:00

feature/158-add_cors #159

alexvanin referenced this issue from a commit

2024-10-25 09:46:46 +00:00

[#158] Rework app settings

alexvanin referenced this issue from a commit

2024-10-25 09:46:46 +00:00

[#158] Fix integration test compilation error

alexvanin referenced this issue from a commit

2024-10-25 09:46:46 +00:00

[#158] Support cors

alexvanin closed this issue

2024-10-25 09:46:46 +00:00

alexvanin added this to the v0.31.0 milestone 2024-11-20 07:56:59 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#158

No description provided.