TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 11 Pull requests 2 Projects Releases 16 Packages 1 Activity Actions

feature/145-make_query_tracing_more_detailed #171

Merged
alexvanin merged 4 commits from r.loginov/frostfs-http-gw:feature/145-make_query_tracing_more_detailed into master 2025-02-07 12:02:37 +00:00
Conversation 0 Commits 4 Files changed 10 +110 -10
r.loginov commented 2024-11-28 08:29:29 +00:00
Member
Copy link

The spans are added to the following layers:

  • handler
  • frosts
  • tree

There are no spans added to middleware, as there are no network interactions.

Examples of what it looks like in jaeger:
Upload:
image
DownloadByS3Path:
image
DownloadByNative:
image
close #145

The spans are added to the following layers: - handler - frosts - tree There are no spans added to middleware, as there are no network interactions. Examples of what it looks like in jaeger: Upload: ![image](/attachments/7214a7ca-1921-4e7f-bac3-a17ee604af50) DownloadByS3Path: ![image](/attachments/bb43861a-aa20-4c36-a4ec-90006853eba5) DownloadByNative: ![image](/attachments/c956e6af-06ff-4424-8678-76322893b0a5) close #145
image.png
83 KiB
image.png
83 KiB
image.png
68 KiB
r.loginov self-assigned this 2024-11-28 08:29:29 +00:00
r.loginov added 3 commits 2024-11-28 08:29:30 +00:00 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
[#145] tree: Add spans to detail the trace
All checks were successful
/ DCO (pull_request) Successful in 2m38s
Details
/ Vulncheck (pull_request) Successful in 3m12s
Details
/ Lint (pull_request) Successful in 3m25s
Details
/ Tests (pull_request) Successful in 1m51s
Details
/ Builds (pull_request) Successful in 2m0s
Details
af53657123 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov added 1 commit 2024-11-28 08:30:15 +00:00
[#145] Update frostfs-observability version
All checks were successful
/ DCO (pull_request) Successful in 1m51s
Details
/ Vulncheck (pull_request) Successful in 1m58s
Details
/ Builds (pull_request) Successful in 2m9s
Details
/ Lint (pull_request) Successful in 4m13s
Details
/ Tests (pull_request) Successful in 2m11s
Details
2cc11d3427 
The new version of frostfs-observability has
improved the detail of tracing low-level rpc
calls by adding send and receive events.

Signed-off-by: Roman Loginov <r.loginov@yadro.com>
requested reviews from alexvanin, dkirillov, pogpp, mbiryukova, nzinkevich 2024-11-28 08:49:56 +00:00
dkirillov reviewed 2024-11-28 14:31:10 +00:00
internal/handler/download.go Outdated
@ -28,10 +29,22 @@ func (h *Handler) DownloadByAddressOrBucketName(c *fasthttp.RequestCtx) {
switch {
case isObjectID(oidURLParam):
ctx, span := tracing.StartSpanFromContext(utils.GetContextFromRequest(c), "handler.DownloadByNativeAddress")
dkirillov commented 2024-11-28 14:31:10 +00:00
Member
Copy link

Just question: Why do we start span here and not in h.byNativeAddress?
The similar situation inside Handler.HeadByAddressOrBucketName

Just question: Why do we start span here and not in `h.byNativeAddress`? The similar situation inside `Handler.HeadByAddressOrBucketName`
r.loginov commented 2024-11-29 07:51:10 +00:00
Author
Member
Copy link

Because h.by Native Address is called in two handlers: DownloadByAddressOrBucketName and HeadByAddressOrBucketName. If you start the span right there, then you will need to give it a name that is not tied to a specific http gate handler - for example, handler.byNativeAddress - however, this name does not answer the question is it a head request or a get request. I thought it would be nice to distinguish which handlers logically work. Similarly with `h.byS3Path'.

Because `h.by Native Address` is called in two handlers: `DownloadByAddressOrBucketName` and `HeadByAddressOrBucketName`. If you start the span right there, then you will need to give it a name that is not tied to a specific http gate handler - for example, `handler.byNativeAddress` - however, this name does not answer the question is it a head request or a get request. I thought it would be nice to distinguish which handlers logically work. Similarly with `h.byS3Path'.
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-11-28 14:31:24 +00:00
Dismissed
dkirillov left a comment
Member
Copy link

LGTM, see minor question

LGTM, see minor question
mbiryukova approved these changes 2024-12-02 03:44:03 +00:00
Dismissed
nzinkevich approved these changes 2024-12-09 06:16:28 +00:00
Dismissed
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 2cc11d3427 to 4395e7e5ac 2024-12-11 13:49:02 +00:00 Compare
r.loginov dismissed dkirillov's review 2024-12-11 13:49:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov dismissed mbiryukova's review 2024-12-11 13:49:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov dismissed nzinkevich's review 2024-12-11 13:49:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexvanin added this to the v0.33.0 milestone 2024-12-12 11:57:57 +00:00
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 4395e7e5ac to 8bdb3d1d93 2024-12-13 11:41:30 +00:00 Compare
dkirillov approved these changes 2024-12-13 12:07:45 +00:00
Dismissed
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 8bdb3d1d93 to 27e36d8843 2024-12-24 05:07:28 +00:00 Compare
r.loginov dismissed dkirillov's review 2024-12-24 05:07:31 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov approved these changes 2024-12-24 09:28:29 +00:00
Dismissed
r.loginov changed title from feature/145-make_query_tracing_more_detailed to WIP: feature/145-make_query_tracing_more_detailed 2025-01-24 08:08:37 +00:00
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 27e36d8843 to 004babe9d3 2025-01-24 08:11:02 +00:00 Compare
r.loginov dismissed dkirillov's review 2025-01-24 08:11:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 004babe9d3 to d5fcc348c4 2025-01-27 06:39:08 +00:00 Compare
r.loginov changed title from WIP: feature/145-make_query_tracing_more_detailed to feature/145-make_query_tracing_more_detailed 2025-01-27 06:45:47 +00:00
requested reviews from storage-services-developers, storage-services-committers 2025-01-27 06:45:47 +00:00
dkirillov approved these changes 2025-01-27 09:51:53 +00:00
Dismissed
alexvanin reviewed 2025-01-29 13:45:33 +00:00
internal/handler/upload.go Outdated
@ -80,6 +83,7 @@ func (h *Handler) Upload(c *fasthttp.RequestCtx) {
return
}
utils.SetContextToRequest(ctx, c)
alexvanin commented 2025-01-29 13:45:33 +00:00
Owner
Copy link

I suggest you to keep utils.SetContextToRequest(ctx, c) near all tracing.StartSpanFromContext which uses context from fasthttp context.

For example DownloadByAddressOrBucketName creates new span, but does not attach it to context and then it invokes c.browseIndex which creates new span. Not sure if this was intended or not, but I would like to see in the trace full path.

I suggest you to keep `utils.SetContextToRequest(ctx, c)` near **all** `tracing.StartSpanFromContext` which uses context from fasthttp context. For example `DownloadByAddressOrBucketName` creates new span, but _does not_ attach it to context and then it invokes `c.browseIndex` which creates new span. Not sure if this was intended or not, but I would like to see in the trace full path.
👍 1
r.loginov commented 2025-01-29 19:42:14 +00:00
Author
Member
Copy link

You're right, I missed this point.
Done.
I went through the whole code again and added the missing utils.SetContextToRequest(ctx, c) to where it is needed.

You're right, I missed this point. Done. I went through the whole code again and added the missing `utils.SetContextToRequest(ctx, c)` to where it is needed.
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from d5fcc348c4 to 2169e6656c 2025-01-29 19:04:06 +00:00 Compare
r.loginov dismissed dkirillov's review 2025-01-29 19:04:07 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 2169e6656c to 078ef0faeb 2025-01-29 19:24:04 +00:00 Compare
r.loginov force-pushed feature/145-make_query_tracing_more_detailed from 078ef0faeb to 033044fcd0 2025-02-03 17:21:56 +00:00 Compare
dkirillov approved these changes 2025-02-04 09:31:09 +00:00
Dismissed
alexvanin force-pushed feature/145-make_query_tracing_more_detailed from 033044fcd0 to 20319418cc 2025-02-07 11:56:05 +00:00 Compare
alexvanin dismissed dkirillov's review 2025-02-07 11:56:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexvanin approved these changes 2025-02-07 11:56:40 +00:00
alexvanin merged commit 20319418cc into master 2025-02-07 12:02:37 +00:00
alexvanin deleted branch feature/145-make_query_tracing_more_detailed 2025-02-07 12:02:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.33.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#171
No description provided.
Delete branch "r.loginov/frostfs-http-gw:feature/145-make_query_tracing_more_detailed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?