GET/HEAD: Add tracing support #20
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-http-gw#20
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-http-gw:feat/OBJECT-3311"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
cd87814c92
to32ff31e941
32ff31e941
to3b7eda465b
WIP: Add tracing supportto GET/HEAD: Add tracing support3b7eda465b
toa32ff4597f
a32ff4597f
toda5d475374
@ -552,0 +555,4 @@
func (a *app) initTracing() {
instanceID := ""
servers := fetchServers(a.cfg)
Why don't we use
a.servers
here?fixed
@ -552,0 +567,4 @@
InstanceID: instanceID,
Version: Version,
}
updated, err := tracing.Setup(context.Background(), cfg)
Why don't we get context as parameter?
fixed
@ -48,2 +48,4 @@
cfgPprofAddress = "pprof.address"
// Tracing ...
cfgTracingEnabled = "tracing.enabled"
We should add this new config parameters to config example and documentation
done
@ -89,3 +91,3 @@
}
func (r request) receiveFile(clnt *pool.Pool, objectAddress oid.Address) {
func receiveFile(ctx context.Context, req request, clnt *pool.Pool, objectAddress oid.Address) {
With changing signature we can drop
appCtx
fromrequest
Done
LGTM, see comments though.
@ -166,6 +167,7 @@ func newApp(ctx context.Context, opt ...Option) App {
a.initAppSettings()
a.initResolver()
a.initMetrics()
a.initTracing()
Should we call
tracing.Shutdown()
neara.stopServices()
call?Sure, fixed
@ -0,0 +26,4 @@
func (c *httpCarrier) Set(key string, value string) {
c.r.Response.Header.Set(key, value)
}
func (c *httpCarrier) Keys() []string {
No empty line between methods?
fixed
da5d475374
to476c74838a
476c74838a
to0e00fdc25e
@ -387,0 +391,4 @@
shdnCtx, cancel := context.WithTimeout(context.Background(), tracingShutdownTimeout)
defer cancel()
if err := tracing.Shutdown(shdnCtx); err != nil {
Can we move this code (that shutdown tracing) to separate function?
done
@ -552,0 +567,4 @@
servers := a.servers
if len(servers) > 0 {
instanceID = servers[0].Address()
}
Let's write:
done
@ -241,0 +248,4 @@
tracing:
enabled: true
exporter: "otlp_grpc"
endpoint: "localhost"
Is there some default port? If so, let's specify it too
done
0e00fdc25e
toa945cdd42c
@alexvanin Should we update CHANGELOG.md?
Going to update in #44